>>> Dave Airlie <airl...@linux.ie> 01.10.09 00:46 >>> >> On 09/30/09 03:13, Jan Beulich wrote: >> > This is for avoiding translation of the passed in address in virtual >> > environments like Xen. >> > >> >> Ah, thanks. I suspected one of these was missing and was about to go >> hunting for it. Do think other DRI drivers are missing this too? >> >> Hm, _PAGE_IOMAP is x86-specific. I guess that doesn't matter in this >> case, but it would for other drivers. Previously _PAGE_IOMAP was set in >> vm_get_page_prot -> arch_vm_get_page_prot. Is that path no longer being >> used? It looks like it should be. > >This patches looks like the wrong answer, not sure why wrapping the GEM >stuff is required, probably should change the drm core not the driver.
I was actually doing this intentionally this way, because I had no reason to believe that drm_gem_mmap() couldn't also be used for allocated memory (where setting _PAGE_IOMAP would be the wrong thing to do). If there is a guarantee that this won't ever be the case, then I agree the adjustment should be done there rather than in a per-driver wrapper. Jan ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
