I've been behind on doing patch reviews trying to get some exec stuff done. My hope is as Tim stated below. Reviewboard for all patches. Start with +1 for committers. Soon, make it +2 for larger patches.
I'll try to get through your review request soon, David. I know that Ted did a high level review but I'm not sure if it was deep enough for him to provide a +1. thanks, J On Tue, Mar 26, 2013 at 2:06 PM, Timothy Chen <[email protected]> wrote: > I think you're the very first to use reviewboard for drill. We used to just > use Github's pull requests before. > > If we are going for reviewboard, then I think all patches should go through > it. > > From recent experience Jacques has been handling all reviews, so I believe > if you have a +1 from a commiter you should be good. > > Tim > > > On Tue, Mar 26, 2013 at 2:02 PM, David Alves <[email protected]> > wrote: > > > Hi All > > > > I have a couple of questions about the review process: > > - should we *always* submit a diff to review board? or should > this > > only be done for "big" patches? > > - how many +1's for a patch to be accepted? +1's only count > > originating from committers, correct? > > > > Best > > David > > >
