I see, then I'll convert all my pending github pull requests into reviewboard too.
Tim On Tue, Mar 26, 2013 at 5:06 PM, Ted Dunning <[email protected]> wrote: > David, > > Reviewboard makes it much easier to review patches so opening additional > review requests only makes things better. > > Regarding commit policy, it is almost always the case with very early > projects that committers will tend a bit toward commit-then-review for > small things. For external contributions and large patches, > review-then-commit is usually a better choice. > > Git is changing that a bit since you can mix the two models by committing > to a fork which can then be reviewed as a single thing. That helps make > the thing that is committed have a bit of a cleaner history (hurray for > rebase) but it does mean that the development is done a little less in the > open, which is a problem relative to Apache projects. > > On Tue, Mar 26, 2013 at 11:32 PM, David Alves <[email protected]> > wrote: > > > Hey Jacques > > > > No worries, I assumed you were probably busy. > > I asked because I was wondering whether I should open review > > requests for other the other patches I've submitted. > > > > Best > > David > > > > On Mar 26, 2013, at 5:26 PM, Jacques Nadeau <[email protected]> wrote: > > > > > I've been behind on doing patch reviews trying to get some exec stuff > > done. > > > My hope is as Tim stated below. Reviewboard for all patches. Start > with > > > +1 for committers. Soon, make it +2 for larger patches. > > > > > > I'll try to get through your review request soon, David. I know that > Ted > > > did a high level review but I'm not sure if it was deep enough for him > to > > > provide a +1. > > > > > > thanks, > > > J > > > > > > On Tue, Mar 26, 2013 at 2:06 PM, Timothy Chen <[email protected]> > wrote: > > > > > >> I think you're the very first to use reviewboard for drill. We used to > > just > > >> use Github's pull requests before. > > >> > > >> If we are going for reviewboard, then I think all patches should go > > through > > >> it. > > >> > > >> From recent experience Jacques has been handling all reviews, so I > > believe > > >> if you have a +1 from a commiter you should be good. > > >> > > >> Tim > > >> > > >> > > >> On Tue, Mar 26, 2013 at 2:02 PM, David Alves <[email protected]> > > >> wrote: > > >> > > >>> Hi All > > >>> > > >>> I have a couple of questions about the review process: > > >>> - should we *always* submit a diff to review board? or should > > >> this > > >>> only be done for "big" patches? > > >>> - how many +1's for a patch to be accepted? +1's only count > > >>> originating from committers, correct? > > >>> > > >>> Best > > >>> David > > >>> > > >> > > > > >
