----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10146/ -----------------------------------------------------------
Review request for drill. Description ------- RSERegistry never stores the engines built in getEngine() into the availableEngines map, which causes a new engine instance to be built in every call and prevents direct interaction with an engine. Specific problem: trying to override a specific configuration for testing doesn't work because getEngine always returns a new instance. Diffs ----- sandbox/prototype/exec/ref/src/main/java/org/apache/drill/exec/ref/rse/RSERegistry.java 4266aac sandbox/prototype/exec/ref/src/test/java/org/apache/drill/exec/ref/RSERegistryTest.java PRE-CREATION Diff: https://reviews.apache.org/r/10146/diff/ Testing ------- Thanks, David Alves
