> On March 28, 2013, 5:07 p.m., Jacques Nadeau wrote: > > Looks good. Thanks for adding the test.
Thanks for reviewing, whenever ready you can +1 and apply/commit either this diff or the patch from DRILL-55, which is updated. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10146/#review18463 ----------------------------------------------------------- On March 27, 2013, 5:10 a.m., David Alves wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10146/ > ----------------------------------------------------------- > > (Updated March 27, 2013, 5:10 a.m.) > > > Review request for drill. > > > Description > ------- > > RSERegistry never stores the engines built in getEngine() into the > availableEngines map, which causes a new engine instance to be built in every > call and prevents direct interaction with an engine. > > Specific problem: trying to override a specific configuration for testing > doesn't work because getEngine always returns a new instance. > > > Diffs > ----- > > > sandbox/prototype/exec/ref/src/main/java/org/apache/drill/exec/ref/rse/RSERegistry.java > 4266aac > > sandbox/prototype/exec/ref/src/test/java/org/apache/drill/exec/ref/RSERegistryTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/10146/diff/ > > > Testing > ------- > > > Thanks, > > David Alves > >
