----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14207/#review26254 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordReader.java <https://reviews.apache.org/r/14207/#comment51324> Can you put the arbitrary as static final constants at the top with their purpose? exec/java-exec/src/test/java/org/apache/drill/exec/store/ParquetRecordReaderTest.java <https://reviews.apache.org/r/14207/#comment51325> What is going on with this line and the next one? exec/java-exec/src/test/java/org/apache/drill/exec/store/ParquetRecordReaderTest.java <https://reviews.apache.org/r/14207/#comment51326> Same here, thinking you should probably update so this are arguments to this method and the test methods call this method. exec/java-exec/src/test/java/org/apache/drill/exec/store/ParquetRecordReaderTest.java <https://reviews.apache.org/r/14207/#comment51327> why did you disable this assertion? - Jacques Nadeau On Sept. 18, 2013, 5:33 p.m., Jason Altekruse wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14207/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2013, 5:33 p.m.) > > > Review request for drill. > > > Bugs: bug, fields, nullable, and parquet > https://issues.apache.org/jira/browse/bug > https://issues.apache.org/jira/browse/fields > https://issues.apache.org/jira/browse/nullable > https://issues.apache.org/jira/browse/parquet > > > Repository: drill-git > > > Description > ------- > > Fix bug described in Drill 238. > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/NullableColumnReader.java > 596108c > > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/PageReadStatus.java > 39d636d > > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordReader.java > fc3ba8c > > exec/java-exec/src/test/java/org/apache/drill/exec/store/ParquetRecordReaderTest.java > 38a624c > > exec/java-exec/src/test/java/org/apache/drill/exec/store/TestParquetPhysicalPlan.java > bdbccf5 > exec/java-exec/src/test/resources/parquet/parquet_pig_nullable.json > PRE-CREATION > exec/java-exec/src/test/resources/parquet/parquet_pig_nullable_bug.json > PRE-CREATION > > exec/java-exec/src/test/resources/parquet/parquet_pig_nullable_bug_unsorted.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/14207/diff/ > > > Testing > ------- > > Full mvn clean install, some tests that required pig generated file > referenced in the jira. > > > Thanks, > > Jason Altekruse > >
