> On Sept. 19, 2013, 1:37 a.m., Jacques Nadeau wrote: > > exec/java-exec/src/test/java/org/apache/drill/exec/store/ParquetRecordReaderTest.java, > > line 175 > > <https://reviews.apache.org/r/14207/diff/1/?file=353424#file353424line175> > > > > What is going on with this line and the next one?
Changed to include both queries in a singe test, as the test was ignored, previously I had been switching out the lines necessary to run each version of the test. > On Sept. 19, 2013, 1:37 a.m., Jacques Nadeau wrote: > > exec/java-exec/src/test/java/org/apache/drill/exec/store/ParquetRecordReaderTest.java, > > line 181 > > <https://reviews.apache.org/r/14207/diff/1/?file=353424#file353424line181> > > > > Same here, thinking you should probably update so this are arguments to > > this method and the test methods call this method. Same as above, I removed some unnecessary parts of the query and just have the two queries being run within one test. > On Sept. 19, 2013, 1:37 a.m., Jacques Nadeau wrote: > > exec/java-exec/src/test/java/org/apache/drill/exec/store/ParquetRecordReaderTest.java, > > line 411 > > <https://reviews.apache.org/r/14207/diff/1/?file=353424#file353424line411> > > > > why did you disable this assertion? Added a flag to disable checking values for some tests. I can validate each value for the generated files, but the file here was a binary based on TPCH that is not in the repo, the test still verifies that the correct number of records were returned and that the correct number of columns are present. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14207/#review26254 ----------------------------------------------------------- On Jan. 4, 2014, 6:14 p.m., Jason Altekruse wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14207/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2014, 6:14 p.m.) > > > Review request for drill. > > > Bugs: bug, fields, nullable, and parquet > https://issues.apache.org/jira/browse/bug > https://issues.apache.org/jira/browse/fields > https://issues.apache.org/jira/browse/nullable > https://issues.apache.org/jira/browse/parquet > > > Repository: drill-git > > > Description > ------- > > Fix bug described in Drill 238. > > > Diffs > ----- > > > exec/java-exec/src/test/java/org/apache/drill/exec/store/CachedSingleFileSystem.java > PRE-CREATION > > exec/java-exec/src/test/java/org/apache/drill/exec/store/ParquetRecordReaderTest.java > 733cb1d > > exec/java-exec/src/test/java/org/apache/drill/exec/store/TestOutputMutator.java > PRE-CREATION > > exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/FieldInfo.java > PRE-CREATION > > exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetRecordReaderTest.java > ab29a9f > > exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetResultListener.java > PRE-CREATION > > exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetTestProperties.java > PRE-CREATION > > exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestFileGenerator.java > d2c95fe > > exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/WrapAroundCounter.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/14207/diff/ > > > Testing > ------- > > Full mvn clean install, some tests that required pig generated file > referenced in the jira. > > > Thanks, > > Jason Altekruse > >
