Hey Jacques, Do you need me to attach this patch to Jira too?
It's also sitting in my github limit_op branch as well. Tim On Tue, Oct 15, 2013 at 9:32 AM, Timothy Chen <[email protected]> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14027/ > Review request for drill and Jacques Nadeau. > By Timothy Chen. > > *Updated Oct. 15, 2013, 4:32 p.m.* > *Repository: * drill-git > Description > > Adding Limit operator end to end > > Diffs (updated) > > - LICENSE (5234110) > - common/src/main/java/org/apache/drill/common/JSONOptions.java > (8157dc6) > - common/src/main/java/org/apache/drill/common/logical/data/Constant.java > (e05ce41) > - common/src/main/java/org/apache/drill/common/logical/data/Limit.java > (93eb182) > - > common/src/main/java/org/apache/drill/common/logical/data/LogicalOperator.java > (9810e75) > - > common/src/main/java/org/apache/drill/common/logical/data/LogicalOperatorBase.java > (29c994f) > - > exec/java-exec/src/main/java/org/apache/drill/exec/opt/BasicOptimizer.java > (5a1fd6e) > - > exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java > (286144b) > - > exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java > (a36b65a) > - > exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/Limit.java > (PRE-CREATION) > - > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java > (94acc0e) > - > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/limit/LimitBatchCreator.java > (PRE-CREATION) > - > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/limit/LimitRecordBatch.java > (PRE-CREATION) > - > exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/StatsCollector.java > (0368d0c) > - > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestSimpleLimit.java > (PRE-CREATION) > - exec/java-exec/src/test/resources/limit/test1.json (PRE-CREATION) > - exec/java-exec/src/test/resources/limit/test2.json (PRE-CREATION) > - exec/java-exec/src/test/resources/limit/test3.json (PRE-CREATION) > - exec/ref/src/main/java/org/apache/drill/exec/ref/rops/LimitROP.java > (00baf81) > - pom.xml (ce1f93d) > - sqlparser/src/main/java/org/apache/drill/optiq/DrillImplementor.java > (6efe60b) > - sqlparser/src/main/java/org/apache/drill/optiq/DrillLimitRel.java > (PRE-CREATION) > - sqlparser/src/main/java/org/apache/drill/optiq/DrillLimitRule.java > (PRE-CREATION) > - sqlparser/src/main/java/org/apache/drill/optiq/DrillOptiq.java > (b01aa7d) > - sqlparser/src/main/java/org/apache/drill/optiq/DrillPrepareImpl.java > (363c064) > - sqlparser/src/main/java/org/apache/drill/optiq/DrillSortRel.java > (b2e9b50) > - sqlparser/src/main/java/org/apache/drill/optiq/DrillSortRule.java > (d5eac2e) > - sqlparser/src/test/java/org/apache/drill/jdbc/test/FullEngineTest.java > (45d1ff3) > - sqlparser/src/test/java/org/apache/drill/jdbc/test/JdbcAssert.java > (e78d5c7) > - sqlparser/src/test/java/org/apache/drill/jdbc/test/JdbcTest.java > (36b024c) > > View Diff <https://reviews.apache.org/r/14027/diff/> >
