Steven Stallion wrote:
>> For dnet, I'd just worry about the MII ones.  You can look at afe to see
>> the "standard set".  (There are some others, such as link pause -- but
>> most dnet devices won't have pause support anyway - they're just too
>> darned old. :-)
>>     
>
> Works for me ;)
>
> I'm thinking that m_setprop may end up being fairly lazy - from what I
> have seen so far dnet will probably not respond very well to dynamic
> updates without a full reset/init. As it is, I do not think changing the
> 'default' properties warrant completely interrupting chip state without at
> least downing the interface first. (FWIW, I believe the Jumbo Frames study
> done in the Brussels spec did something similiar, i.e. lazy
> changes/waiting for the next reset/sync)
>   

Uh, no.  You should make MII changes take effect immediately.

>   
>> No, I need to review it, and unfortunately, I'm pretty well saturated
>> right now.  I *will* review your changes soon, promise.
>>     
>
> No worries, I'm kicking myself for chasing SYM support for so long; this
> patch only had two additional lines for link notification and minor
> cosmetic fixes compared to the one submitted in April.
>   

Understood. :-)

    -- Garrett
> Cheers,
>
> Steve
>
>   

_______________________________________________
driver-discuss mailing list
driver-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/driver-discuss

Reply via email to