Xiu-Yan Wang wrote: > > 1. usr/src/pkgdefs/SUNWsfxge/depend is not needed as it will be > generated automatically by nightly. >
Ok. > 2. aliases with pciex prefix are needed to be added to postinstall. > Or add_drv may fail on some sparc systems. > Good point; I'd missed that. > 3. "link up" or "link down" message will be printed in the console when > the link state changes. This is not desired as it may flood the > console. As proposed by PSARC/2007/298 GLDv3 link status logging, > the change of link state is handled at GLD layer by > i_mac_log_link_state(), which will log the message to the system log > file. And there is no need for the driver to handle this. > Ok. They're really there for debugging but I guess they need to be removed for integration. Thanks for the review, Paul _______________________________________________ driver-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/driver-discuss
