Hi Paul,
Here are my comments so far:
1. usr/src/pkgdefs/SUNWsfxge/depend is not needed as it will be
generated automatically by nightly.
2. aliases with pciex prefix are needed to be added to postinstall.
Or add_drv may fail on some sparc systems.
3. "link up" or "link down" message will be printed in the console when
the link state changes. This is not desired as it may flood the
console. As proposed by PSARC/2007/298 GLDv3 link status logging,
the change of link state is handled at GLD layer by
i_mac_log_link_state(), which will log the message to the system log
file. And there is no need for the driver to handle this.
Thanks,
Lucy
Paul Durrant wrote:
> Hi,
>
> I urgently need reviewers for some changes to Solaris I plan to make
> along with the integration of my driver. There is a webrev at
> http://cr.opensolaris.org/~pdurrant/webrev/ detailing the changes.
> Specifically, the changes are:
>
> - in linkprop.c: add extra MAC_PROP_ entries for 10G
> - in ip.c: remove the multipkttcp code
> - in ip_stack.h: remove the ip_multipkttcp kstat
> - in mac_ether.c: add extra stats for autonegotiated 10G links
> - in softmac_stat.c: remove some implicit dependencies on array lengths
> that led to panics during testing (i.e. make the code more robust)
> - in stream.c: add support of xesballoc()
> - in streamio.c: prevent needless pullups of multifragment packets
> - in mac.h: add definitions for extra MAC_PROP_ entries
> - in mac_ether.h: add definitions for extra stats
> - in stream.h: add prototype for xesballoc()
> - in strft.h: add flowtrace event for xesballoc()
>
> There are also several mods. (and one additional file) to introduce
> prefetching inlines:
>
> - amd64.il
> - intel/asm/cpu.h
> - ia32.il
> - intel/sys/cpu.h
> - sparc/asm/cpu.h
> - sparc.il
> - sparc/sys/cpu.h
>
> The rest of the webrev is concerned with the new (sfxge) driver and its
> packaging. I also need review of this code a.s.a.p.
>
> Thanks,
>
> Paul
> _______________________________________________
> driver-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/driver-discuss
>
_______________________________________________
driver-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/driver-discuss
