Roy Lyseng wrote: > Jay Pipes wrote: >> Brian Aker wrote: >>> Hi! >>> >>> My roadblock in getting I_S, FRM, etc done is coming up with a new >>> serialized form of a table definition. I've found that I really like >>> what Google has done with Protobuffers. >>> >>> This is the definition I have thus far: >>> http://drizzle.wikia.com/wiki/Table_Proto_Definition#Current_Definition >> >> Good work so far. Here are a few comments: >> >> 1) Consistency is a Good Thing :) >> >> For some bool attributes, there is a is_ prefix (like is_unsigned). For >> others, like primary and key and auto_increment, there is no prefix. >> Let's stick to one or the other. Personally, I prefer the is_ prefix as >> it makes the resulting code more explicit and readable. > > Sure? I would expect methods to have the is_ prefix, but not the fields: > > int unsigned; > > int is_unsigned() > { return signed; > }
Hi! Understood, Roy. The only thing is that Google Proto Buffers, when compiling the .proto files into classes converts the attributes into methods, so the is_unsigned attribute actually becomes: Field::is_unsigned(); in the C++ source code which uses the compiler-generated classes. Cheers, Jay _______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
