Paul McCullagh wrote: > Paul McCullagh has proposed merging ~paul-mccullagh/drizzle/test-patches into > Drizzle Active Development Branch. > > Whiteboard: > This branch includes several changes to the test system. It makes it possible > to run drizzle-test-run with multiple engines (currently PBXT and InnoDB). > > - Added --engine=x option to drizzle-test-run (default innodb): > > This option can be used to set the default engine for the test run. > It sets the --default-storage-engine option when starting the server. > It will also check the engine specific result directory, for example > r/pbxt for the pbxt engine. If a result file is in this directory > then it will be used instead of the "generic" result in the r/ > directory. > > - Changes to .test files for running with PBXT include: > > * Added comments of the for "# PBXT ..." where results differ > between InnoDB and PBXT, and it is not obvious why. > * Added --sorted_result to SELECTs that have no ORDER BY and return > rows in a different order when using InnoDB. > * Added --replace_regex /ENGINE=[a-z]*/ENGINE=X/i to SHOW CREATE > TABLE statements. > * Removed "engine=innodb" from some CREATE TABLE statement where > the test was generic enough to work with PBXT. > > - Changes to .result files: > > These changes are due to sorted results, etc. (see above) > > - Added the parameter lock_open_lock to mysql_create_table_no_lock() > > This is required because PBXT needs to call mysql_create_table_no_lock() > to create a .frm file. However, when the call is done, the > LOCK_open lock is already held. So this parameter indicates if the > lock must be aquired or not. > > - Fixes to drizzletest: > > * Fixed the --sorted_result command and changed to sorting ascending. > * Fixed the --replace_regex command. > > - Added PBXT specific result files: > > These files are located in the tests/r/pbxt directory. They are > result files that apply to PBXT only, and are only used > if dtr is started with the option --engine=pbxt. > And the PBXT engine must be linked into the server as well, of > course.
Great. All of this looks good. > - Added a --with-debug=full option to configure > > This option is identical to --with-debug=yes except that it > defined DEBUG on the command line (-DDEBUG). PBXT uses the DEBUG > define in order to turn on assertions on, and to added other > runtime checking. I don't have a problem with this in general... however, may I recommend the NDEBUG flag for turning assertions off (which is a standard define and what assert.h uses). Obviously not suggesting you need to patch all of PBXT right now... but I thought I just might make the suggestion while we're talking about it. If you did that, then you can make use of our --enable-assert/--disable-assert flag. Also, is there a reason why we can't just define -DDEBUG with regular --with-debug? I'm not sure that --with-debug does a whole lot special for us at the moment anyway other than turning off -O3. Monty -- https://code.launchpad.net/~paul-mccullagh/drizzle/test-patches/+merge/1275 You are subscribed to branch Drizzle Active Development Branch. _______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
