On Oct 10, 2008, at 10:33 AM, Monty Taylor wrote: >> Basically it is not good if a production build of PBXT includes >> assertions (because every little instruction is bad!) >> >>> Also, is there a reason why we can't just define -DDEBUG with >>> regular >>> --with-debug? I'm not sure that --with-debug does a whole lot >>> special >>> for us at the moment anyway other than turning off -O3.
Yes, I see your point! :) >> Actually I hesitated to change --with-debug=yes because currently the >> only difference between yes and no is that yes adds "-g" and no adds >> "-03". >> >> This can be useful because sometimes I find that I cannot repeat a >> bug >> when turning on my DEBUG code because of timing issues. So it helps >> to >> be able to build (an otherwise standard production system) with >> just -g. >> >> On the other hand it makes sense to define the DEBUG flag with -- >> with- >> debug=yes, because normally the check code helps to find bugs. >> >> So maybe we should add DEBUG to --with-debug=yes, but then add a >> configure option like --with-debug=symbols (or "only", ...) which >> simply adds -g? > > crap. That'll teach me to look at code at 1:30AM. ... the > SYMBOLS_CFLAGS > does the right thing already... it's set to either -ggdb3 for gcc or > -g > for non-gcc, and is unconditionally added to CFLAGS. (same for > SYMBOLS_CXXFLAGS and CXXFLAGS) So there is currently no way to disable > -g. :) Oops, I missed that too! So should we just add -DDEBUG to --with-debug=yes, and leave it at that? Let me know if I should push any changes to this tree, before you can merge... -- Paul McCullagh PrimeBase Technologies www.primebase.org www.blobstreaming.org pbxt.blogspot.com -- https://code.launchpad.net/~paul-mccullagh/drizzle/test-patches/+merge/1275 You are subscribed to branch Drizzle Active Development Branch. _______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
