On Sun, Mar 01, 2009 at 09:49:51PM +0900, Toru Maesaka wrote: > sql_parse_vcol_expr(Session *session, const char *vcol_expr, > const size_t length); > > > this is due to the way unpack_vcol_info_from_frm() in table.cc relies > on a direct call to the parser to translate the virtual column expression > from a .frm file into an Item object. So, I needed a way to directly call > the raw parser without going through housekeeping. > > I reaaaaaally don't want this function but to kill this thing, we need to > come up with a way to create a virtual column object without relying > on the parser. Either that or I think we can kill this function when > Drizzle doesn't need .frm files anymore. I think this is currently being > worked on?
(haven't looked at your tree yet... but from a "just spent a lot of time looking at FRM related code POV): I'm not sure if we can avoid this.... what would be cool is to have it be able to use pluggable parsers. i.e. have CREATE TABLE in SQL have a virtual column in some-other-language-that-we-parse and vice versa. This can, of course, be a "future work" thing. But if we're going to have virtual columns, we'll have to use the parser for that func for the virtual column. -- Stewart Smith _______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
