What is the impact of those comments on the parser? I seem to
remember an earlier discussion to just remove them over conflict
creation.
Cheers,
--Brian
On Mar 3, 2009, at 1:04 AM, Monty Taylor <[email protected]> wrote:
Hey all,
MySQL supports a special form of comments, like /*!50132 foo()*/ which
means that it's a comment for versions before 5.1.32, and executes
foo()
for versions 5.1.32 and above.
The scheme is exactly 5 digits directly after the /*!
In Drizzle, we've just decided on version numbers of the form
2009.03.911, which are YYYY.MM.REVNO. I'm pretty sure revno is going
to
top 1000 reasonably soon, and it's not inconceivable that it tops
10000
at some point.
To support this in the code, I changed it from being 5 digits directly
after the /*!, to being 5 or more digits, ending with a non-digit.
This
means that:
select 1 + /*!500021*/;
will be a syntax error rather 2, and would have to be written:
select 1 + /*!50002 1*/;
And that now you can do:
select 1 + /*!200804900 1*/;
Anybody think this change will be a big problem?
Monty
_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help : https://help.launchpad.net/ListHelp
_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help : https://help.launchpad.net/ListHelp
