On Thu, Apr 02, 2009 at 08:43:38PM -0400, Jay Pipes wrote: > 1) > > Rename the /drizzled/serialize/ directory to /drizzled/message to more > properly communicate the fact that classes and protos defined in that > directory are for protobuffer derived Message classes. "serialize" > implies that the directory contains some utilities for just serializing > data, which is partly correct, but the classes are of class "Message", > not "Serialize". Just like our Field classes are in /drizzled/field, etc...
I'm not as familiar with that code, but does it make sense to do directories per protobuf type (and put related code in each)? Seems strange that table classes are in the same directory as replication classes. > 2) > > Rename the drizzle:: namespace currently being used for the table proto > (and very, very soon for the replication event protos) to namespace > drizzled::message. ++ Keep the 'drizzle' namespace (and prefixes for classes, enum, #defines, ...) for client stuff. -Eric _______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
