On Wed, Jul 08, 2009 at 10:56:05AM -0700, Brian Aker wrote:
> 1) Don't use "struct" for a struct. This is C++, isn't needed at all.

The two possible exceptions I kind of like are if it's going over the wire or to
disk and is __attribute__ packed.

> 2) Don't use typedef with struct.

...unless it's used to abstract a basic type (e.g. like in my_socket.h
to get socket portability across UNIX and Win32).

> 3) I noticed that the codestyle for comments was updated for this  
> (unless I am wrong):
>
> /**
> *
> *
> *
> */
>
> The "*" on a blank line. I gotta say... I am not in favor of it. In very 
> large part because my editor keeps screwing it up :)
>
> I don't see the need for it... but I can go with majority on it. Though 
> if someone has a vim recipe for this... I am game.

it does slightly aid being able to pick a comment out of a list of
things thrown out by grep as the leading * pretty much ensures that line
could never compile. Without it... may be left guessing without
surrounding context.

-- 
Stewart Smith

_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help   : https://help.launchpad.net/ListHelp

Reply via email to