Padraig O'Sullivan wrote: > Hi Paul, > > On Wed, Nov 11, 2009 at 5:39 AM, Paul McCullagh > <[email protected]> wrote: >> Hi Padraig, >> >> Thanks! I have committed the changes to the PBXT trunk. > > Cool. Thanks! > >> Just one change I am not sure of: >> >> datalog_xt.cc: line 1206 >> >> #ifdef DEBUG >> if (dlb_buffer_offset + (xtLogOffset) dlb_buffer_len > >> dlb_max_write_offset) >> dlb_max_write_offset = dlb_buffer_offset + >> (xtLogOffset) dlb_buffer_len; >> #endif >> >> --> >> >> #ifdef DEBUG >> if (dlb_buffer_offset + dlb_buffer_len > >> dlb_max_write_offset) >> dlb_max_write_offset = dlb_buffer_offset + >> (xtLogOffset) dlb_buffer_len; >> #endif >> >> This is a case of "off_t + size_t > off_t". >> >> The size_t was cast to an off_t in case size_t is 4 bytes and off_t is 8. >> >> So we want to make sure that the calculation is done using 8 byte values in >> this case. >> >> Did you get a warning on this line? Maybe due to signed to unsigned >> conversion? > > Sorry, that's my bad. I meant to revert that change before commiting. > Yes, I had gotten a warning to do with comparison of signed and > unsigned integers in a few places in that file. I was going to try and > fix those warnings but then decided it would be better to not do that > and just updated the compiler flags to include -Wno-sign-compare > instead.
Well... you can't just add that to the flags in the Makefile, because it's not a valid Sun Studio flag. Personally I would suggest fixing the warnings, but that's the way I roll. Other options are that we build pbxt itself with no warnings and only build the handler with warnings... OR we can add some autoconf code to inject/not-inject that flag. >> On Nov 11, 2009, at 4:02 AM, Padraig O'Sullivan wrote: >> >>> Hi Jay and Paul, >>> >>> I was messing around and pushed the changes to get PBXT to compile >>> with drizzle trunk. I pushed them to the tree you specified. Let me >>> know if there any issues with anything I did. >>> >>> I tried running the test suite with PBXT and like you said, a number >>> of the test cases fail. Hopefully, we can help out with that too if >>> possible. >>> >>> -Padraig >>> >>> On Tue, Nov 10, 2009 at 1:37 PM, Paul McCullagh >>> <[email protected]> wrote: >>>> On Nov 10, 2009, at 6:45 PM, Jay Pipes wrote: >>>> >>>>> Oh, and BTW, you're always welcome to come hang out on Freenode IRC >>>>> #drizzle you know ;) >>>> Yes, thanks, I know... :) >>>> >>>>> >>>>> Paul McCullagh wrote: >>>>>> Hi Brian, >>>>>> As I mentioned last night we now have PBXT ported to the latest version >>>>>> of Drizzle. >>>>>> I have pushed the changes to: lp:~drizzle-pbxt/drizzle/drizzle-pbxt-2 >>>>>> Quite a few of the tests still fail, and we are working on getting >>>>>> those >>>>>> fixed. >>>>>> The version of PBXT is 1.0.09, and the version of Drizzle is also a >>>>>> couple of weeks old. >>>>>> So if there have been any recent changes to the engine interface (or >>>>>> table creation stuff), then we will need another round of updates. >>>>>> Anyone wanting to give us a hand with this is welcome! The tree is >>>>>> owned >>>>>> by Drizzle-PBXT (of which Drizzle-developers is a member) - no change >>>>>> proposal required, just push! >>>>>> Vlad and I will review any changes before we move them back in the PBXT >>>>>> trunk, and make adjustments if necessary. >>>>>> I would like to get PBXT 1.1 in as soon as possible as well. >>>>>> Best regards, >>>>>> Paul >>>>>> -- >>>>>> Paul McCullagh >>>>>> PrimeBase Technologies >>>>>> www.primebase.org >>>>>> www.blobstreaming.org >>>>>> pbxt.blogspot.com >>>>>> _______________________________________________ >>>>>> Mailing list: https://launchpad.net/~drizzle-discuss >>>>>> Post to : [email protected] >>>>>> Unsubscribe : https://launchpad.net/~drizzle-discuss >>>>>> More help : https://help.launchpad.net/ListHelp >>>> >>>> >>>> -- >>>> Paul McCullagh >>>> PrimeBase Technologies >>>> www.primebase.org >>>> www.blobstreaming.org >>>> pbxt.blogspot.com >>>> >>>> >>>> >>>> >>>> _______________________________________________ >>>> Mailing list: https://launchpad.net/~drizzle-discuss >>>> Post to : [email protected] >>>> Unsubscribe : https://launchpad.net/~drizzle-discuss >>>> More help : https://help.launchpad.net/ListHelp >>>> >> >> >> -- >> Paul McCullagh >> PrimeBase Technologies >> www.primebase.org >> www.blobstreaming.org >> pbxt.blogspot.com >> >> >> >> > > _______________________________________________ > Mailing list: https://launchpad.net/~drizzle-discuss > Post to : [email protected] > Unsubscribe : https://launchpad.net/~drizzle-discuss > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
