On Nov 11, 2009, at 3:42 PM, Monty Taylor wrote:
Padraig O'Sullivan wrote:
Hi Paul,
On Wed, Nov 11, 2009 at 5:39 AM, Paul McCullagh
<[email protected]> wrote:
Hi Padraig,
Thanks! I have committed the changes to the PBXT trunk.
Cool. Thanks!
Just one change I am not sure of:
datalog_xt.cc: line 1206
#ifdef DEBUG
if (dlb_buffer_offset + (xtLogOffset) dlb_buffer_len >
dlb_max_write_offset)
dlb_max_write_offset = dlb_buffer_offset +
(xtLogOffset) dlb_buffer_len;
#endif
-->
#ifdef DEBUG
if (dlb_buffer_offset + dlb_buffer_len >
dlb_max_write_offset)
dlb_max_write_offset = dlb_buffer_offset +
(xtLogOffset) dlb_buffer_len;
#endif
This is a case of "off_t + size_t > off_t".
The size_t was cast to an off_t in case size_t is 4 bytes and
off_t is 8.
So we want to make sure that the calculation is done using 8 byte
values in
this case.
Did you get a warning on this line? Maybe due to signed to unsigned
conversion?
Sorry, that's my bad. I meant to revert that change before commiting.
Yes, I had gotten a warning to do with comparison of signed and
unsigned integers in a few places in that file. I was going to try
and
fix those warnings but then decided it would be better to not do that
and just updated the compiler flags to include -Wno-sign-compare
instead.
Well... you can't just add that to the flags in the Makefile, because
it's not a valid Sun Studio flag. Personally I would suggest fixing
the
warnings, but that's the way I roll. Other options are that we build
pbxt itself with no warnings and only build the handler with
warnings...
OR we can add some autoconf code to inject/not-inject that flag.
I would like to fix the code. Other options not good! :)
_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help : https://help.launchpad.net/ListHelp
