Hopefully, we can remove the exception in the future, since there is really no good reason for non-private data members at all.
-jay On Wed, Feb 10, 2010 at 8:56 PM, Padraig O'Sullivan < [email protected]> wrote: > On Wed, Feb 10, 2010 at 8:04 PM, Monty Taylor <[email protected]> > wrote: > > Stewart Smith wrote: > >> On Wed, Feb 10, 2010 at 09:05:47AM -0500, Jay Pipes wrote: > >>> I strongly disagree. Cache misses did not suddenly eclipse LOCK open or > the > >>> parser's poor performance just because someone's been playing around > with > >>> pahole. > >> > >> LOCK_open is rather nasty.... but after that.. I suspect we can get > >> something better from making a bunch of oru data structures better > >> cache aligned - especially in hot code paths. > >> > >> Mutexes are still murder though. > >> > > > > To sum up - I think the text padraig proposed and brian amended is > > correct and doesn't conflict with anything: > > Cool. I updated the coding standards with the appropriate text tonight: > > http://drizzle.org/wiki/Coding_Standards#Declaration_Order > > Thanks for the input! > > > > > > > "Your class definition should start with its public: section, > > followed by its protected: section and then its private: section. If > > any of these sections are empty, omit them. > > > > Exceptions will be made for cache alignment." > > > > Monty > > > > _______________________________________________ > > Mailing list: > > https://launchpad.net/~drizzle-discuss<https://launchpad.net/%7Edrizzle-discuss> > > Post to : [email protected] > > Unsubscribe : > > https://launchpad.net/~drizzle-discuss<https://launchpad.net/%7Edrizzle-discuss> > > More help : https://help.launchpad.net/ListHelp > > > > _______________________________________________ > Mailing list: > https://launchpad.net/~drizzle-discuss<https://launchpad.net/%7Edrizzle-discuss> > Post to : [email protected] > Unsubscribe : > https://launchpad.net/~drizzle-discuss<https://launchpad.net/%7Edrizzle-discuss> > More help : https://help.launchpad.net/ListHelp >
_______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
