[
http://jira.dspace.org/jira/browse/DS-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10639#action_10639
]
Kim Shepherd commented on DS-246:
---------------------------------
As noted in subsequent emails, the hidden form field used by the 'secondary
navigation' form (used when the browser clicks "Go", for instance) is still
using an encoded filter value. I'm having a lot of trouble weeding it out
without stuffing up the places where that value needs to be encoded for links
(eg. the alphabet links, previous page, next page). Will submit a new patch
shortly, but it's slightly frustrating that we're having to redo so much of the
browse navigation code because of this new 'feature' of URLDecode. Aside from
anything else, it should only really be replacing '%' characters that aren't
part of encoded symbols already (ie. % followed by space, or string terminator,
or another % symbol)... correct?
> XMLUI - DSpaceAbstractTransformer URLDecode '%' escaper is too greedy
> ---------------------------------------------------------------------
>
> Key: DS-246
> URL: http://jira.dspace.org/jira/browse/DS-246
> Project: DSpace 1.x
> Issue Type: Bug
> Components: XMLUI
> Affects Versions: 1.5.2, 1.6.0
> Environment: Tomcat 5 and Tomcat 6
> Reporter: Kim Shepherd
> Assignee: Kim Shepherd
> Fix For: 1.6.0
>
> Attachments: patch_configurable_browse_form_wrongly_URLEncoded.txt
>
>
> As per Jennifer Whalan's email to dspace-tech:
> "On any of the authors, which have a comma, or I am assuming any other
> non-alphabet character, if you change either one of the sort-by, order or
> number of results and then click update, the page it displays has no items
> showing, and it seems to be using the encoding of the comma. You can try it
> here:
> http://www.territorystories.nt.gov.au/browse?value=Aagaard%2C+Jane.&type=author.";
> The same issue is appearing on my (1.6.0 snapshot) test instance at:
> http://test.anonymous.org.nz:8180/browse?value=Abarca%2C+Nureya&type=author
> My suspicion is that either some 'auto URL encoding' is taking place in
> Cocoon 2.2 that didn't happen in Cocoon 2.1, or we're not decoding correctly
> when populating hidden form fields for configurable browse (odd, since we're
> displaying a clean version at that stage..)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
