[
http://jira.dspace.org/jira/browse/DS-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10640#action_10640
]
Kim Shepherd commented on DS-246:
---------------------------------
Quoting from http://www.ietf.org/rfc/rfc2396.txt (section 2.4.2):
Because the percent "%" character always has the reserved purpose of
being the escape indicator, it must be escaped as "%25" in order to
be used as data within a URI. Implementers should be careful not to
escape or unescape the same string more than once, since unescaping
an already unescaped string might lead to misinterpreting a percent
data character as another escaped character, or vice versa in the
case of escaping an already escaped string.
(end quote)
Unfortunately I think quite a few XMLUI 'tricks' handling, for instance,
browse/user parameters that are both included as hidden form inputs and
rendered in xref links do end up decoding/encoding strings more than once,
which is how we've fallen into this trap once we explicitly escape %.
> XMLUI - DSpaceAbstractTransformer URLDecode '%' escaper is too greedy
> ---------------------------------------------------------------------
>
> Key: DS-246
> URL: http://jira.dspace.org/jira/browse/DS-246
> Project: DSpace 1.x
> Issue Type: Bug
> Components: XMLUI
> Affects Versions: 1.5.2, 1.6.0
> Environment: Tomcat 5 and Tomcat 6
> Reporter: Kim Shepherd
> Assignee: Kim Shepherd
> Fix For: 1.6.0
>
> Attachments: patch_configurable_browse_form_wrongly_URLEncoded.txt
>
>
> As per Jennifer Whalan's email to dspace-tech:
> "On any of the authors, which have a comma, or I am assuming any other
> non-alphabet character, if you change either one of the sort-by, order or
> number of results and then click update, the page it displays has no items
> showing, and it seems to be using the encoding of the comma. You can try it
> here:
> http://www.territorystories.nt.gov.au/browse?value=Aagaard%2C+Jane.&type=author.";
> The same issue is appearing on my (1.6.0 snapshot) test instance at:
> http://test.anonymous.org.nz:8180/browse?value=Abarca%2C+Nureya&type=author
> My suspicion is that either some 'auto URL encoding' is taking place in
> Cocoon 2.2 that didn't happen in Cocoon 2.1, or we're not decoding correctly
> when populating hidden form fields for configurable browse (odd, since we're
> displaying a clean version at that stage..)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
