[ 
http://jira.dspace.org/jira/browse/DS-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10722#action_10722
 ] 

Andrea Bollini commented on DS-217:
-----------------------------------

Hi Larry,
yes, the patch is already complete as is but... I will like to add a "preview" 
function to check the license content because if a typo occur, a percent not 
rightly escaped, etc., it will break the submission process. What do you think? 
should we commit the patch now and add the preview function later?

> Hardcoded String in the license bitstream
> -----------------------------------------
>
>                 Key: DS-217
>                 URL: http://jira.dspace.org/jira/browse/DS-217
>             Project: DSpace 1.x
>          Issue Type: Bug
>          Components: DSpace API
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2
>            Reporter: Andrea Bollini
>            Assignee: Andrea Bollini
>            Priority: Minor
>         Attachments: d, DS-217-substitution-variable-license.patch
>
>
> The Item's licenseGranted method hardcoded the string:
> "License granted by " + eperson.getFullName() + " (" + eperson.getEmail() + 
> ") on "+ DCDate.getCurrent().toString() + " (GMT):\n\n"
> at the start of the license bitstream. This is not desiderable for some user 
> that like to have this text translated and/or in a different position.
> Moreover, could be appropriate move this method in the LicenseStep processing 
> class? should we allow the license text itself to contain parameter that will 
> be replaced at runtime with current user data and date so that the license 
> showed to the user will be exactly the same that will be stored?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to