[
http://jira.dspace.org/jira/browse/DS-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10726#action_10726
]
Larry Stone commented on DS-217:
--------------------------------
The submission step where you approve the license already serves as a preview
--
dspace-xmlui/dspace-xmlui-api/src/main/java/org/dspace/app/xmlui/aspect/submission/submit/LicenseStep.java
puts the license text with subsitutions into the page that is shown to the
user to approve.
When I was testing the patch that's how I checked variable substitution: I just
submitted a bogus Item and aborted it after displaying the license. That
seems more obvious to me than a whole separate UI page to preview licenses
(since there would have to be links to it, and documentation, etc..). Since
you can still quit the submission process without creating an Item, it seems
like an effective and harmless way to test the license. If you're debugging a
license, you can just leave the submission in progress and go back to the
license-approval page to test each new attempt.
It's even easier to remember than a separate preview page, since anyone
tinkering with license texts ought to know how the rest of the submission
process works and be able to get through it quickly. So, I recommend
committing this patch and documenting my method of testing licenses.
> Hardcoded String in the license bitstream
> -----------------------------------------
>
> Key: DS-217
> URL: http://jira.dspace.org/jira/browse/DS-217
> Project: DSpace 1.x
> Issue Type: Bug
> Components: DSpace API
> Affects Versions: 1.5.0, 1.5.1, 1.5.2
> Reporter: Andrea Bollini
> Assignee: Andrea Bollini
> Priority: Minor
> Attachments: DS-217-substitution-variable-license.patch
>
>
> The Item's licenseGranted method hardcoded the string:
> "License granted by " + eperson.getFullName() + " (" + eperson.getEmail() +
> ") on "+ DCDate.getCurrent().toString() + " (GMT):\n\n"
> at the start of the license bitstream. This is not desiderable for some user
> that like to have this text translated and/or in a different position.
> Moreover, could be appropriate move this method in the LicenseStep processing
> class? should we allow the license text itself to contain parameter that will
> be replaced at runtime with current user data and date so that the license
> showed to the user will be exactly the same that will be stored?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
