[
http://jira.dspace.org/jira/browse/DS-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11573#action_11573
]
Claudia Jürgen commented on DS-587:
-----------------------------------
Hi Jose,
some thoughts at first glance, just looking at this entry haven't tested the
patch yet.
One should distinguish between embargoed items and withdrawn items. Withdrawn
items have been public before and embargoed items are not yet published. So a
tombstone should differentiate between that. The reason should be configurable
and i18n (as the lot).
As for the patch, best take a look at the contribution guidelines
https://wiki.duraspace.org/display/DSPACE/ContributionGuidelines
The first thing I noted was that it was a) not internationalized b) customized
(i.e. referring to Deep Blue instead of DSpace).
One other thing, at some point above you are making assumptions about the
number of times the metadatavalue dc.description.provenance is available. Note,
these numbers may vary. An entry is made during:
- submission
- workflow step 1
- workflow step 2
- on each withdrawal
- on each reinstantiation
so the number may vary between 1..n (or 0..n if by some mistake during edit
item dc.description.provenance is deleted).
Have a nice day
Claudia Jürgen
> add the capability to indicate a withdraw reason to an item ( tombstone )
> -------------------------------------------------------------------------
>
> Key: DS-587
> URL: http://jira.dspace.org/jira/browse/DS-587
> Project: DSpace 1.x
> Issue Type: New Feature
> Components: JSPUI
> Affects Versions: 1.6.0
> Environment: This is a change to the base functionality of the jspui.
> Reporter: Jose Blanco
> Priority: Minor
> Attachments: confirm-withdraw-item.jsp, embargo.jsp, tombstone.jsp
>
> Original Estimate: 0 minutes
> Remaining Estimate: 0 minutes
>
> I have already made the changes to our instance of dspace. Here is an
> explanation of what the tombstone functionality works at our instance.
> When an item is withdrawn the user is presented with these options for
> the reason of withdraw ( these reasons live in the file
> tools/confirm-withdraw-item.jsp ):
> Removed from view by legal order.
> Removed from view by the University of Michigan.
> Removed from view at request of the author.
> The user makes his selection and the item is withdrawn. When the item is
> accessed the reason for the withdraw is
> displayed in the box containing the bitstreams.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
This SF.net email is sponsored by
Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev
_______________________________________________
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel
