[
http://jira.dspace.org/jira/browse/DS-637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Donohue updated DS-637:
---------------------------
Assignee: Andrea Bollini
Was discussed during DSpace Devel Mtg on Oct 6 2010.
We decided that this looks like a good fix, provided that Andrea Bollini
approves of it. Andrea, I've assigned this issue for you to review & test.
Assuming it looks good, feel free to commit it to Trunk.
Here's our full discussion from mtg:
[20:27] <tdonohue> 1.6.2 browse index bug/fix for authority index :
http://jira.dspace.org/jira/browse/DS-637
[20:28] <richardrodgers> +1 if Andrea agrees
[20:28] <richardrodgers> (which I think he did)
[20:28] <tdonohue> +1 as well -- assign to Andrea to test/confirm?
[20:29] <mhwood> +1
[20:29] <keithgilbertson> +1
[20:29] <tdonohue> yea, from email thread, it looks like Andrea already
"volunteered" to fix it. I'll assign this to him for investigation/verification
and then commit to trunk
[20:30] <tdonohue> DS-637 - assign to andrea for verification & commit
> 1.6.2 browse index bug/fix for authority index
> ----------------------------------------------
>
> Key: DS-637
> URL: http://jira.dspace.org/jira/browse/DS-637
> Project: DSpace 1.x
> Issue Type: Bug
> Affects Versions: 1.6.0, 1.6.1, 1.6.2
> Reporter: Reinhard Engels
> Assignee: Andrea Bollini
> Attachments: IndexBrowse.java.patch
>
>
> Here's the description of the issue that I posted to:
> http://www.mail-archive.com/[email protected]/msg11429.html
> (per Andrea's suggestion, I've attached a patch file to be applied to
> dspace-1.6.2-src-release/dspace-api/src/main/java/org/dspace/browse/IndexBrowse.java)
> ********************************************************************
> Hi fellow dspacers,
> We just noticed that our authority browse index was only including
> items for which the first author is recognized. A recognized author in
> any other position wasn't good enough. So a significant number of
> items that should have been in our browse index weren't.
> Here's the relevant dspace.cfg entry:
> webui.browse.index.4 =
> harvardAuthor:metadataAuthority:dc.contributor.author:authority
> I took a look at
> dspace-api/src/main/java/org/dspace/browse/IndexBrowse.java and it
> looks like there's a "break;" around line 450 that should be a
> "continue;"
> Here's the context:
> if (bis[i].isAuthorityIndex() &&
> (values[x].authority
> == null || values[x].confidence < minConfidence))
> {
> // if we have an authority
> index only authored metadata will go here!
> log.debug("Skipping
> item="+item.getID()+",
> field="+values[x].schema+"."+values[x].element+"."+values[x].qualifier+",
> value="+values[x].value+", authority="+values[x].authority+",
> confidence="+values[x].confidence+" (BAD AUTHORITY)");
> break; //////////////
> Reinhard thinks this should be a "continue"???
> }
> Changing the "break" to a "continue" makes logical sense to me insofar
> as I understand what is going on, and so far it has seemed to fix the
> problem for us. But it's in a rather complex region of code and I'm
> still a bit of a dspace newbie, so it's quite possible that this isn't
> the ideal fix (and perhaps has side effects that I haven't yet
> realized).
> I'm hoping perhaps a more seasoned dspace guru could take a look?
> Thanks in advance -- and please let me know if you need more information.
> Reinhard
> **************************************************************************************
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
Spend less time writing and rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
