[
https://jira.duraspace.org/browse/DS-672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18906#action_18906
]
Mark H. Wood commented on DS-672:
---------------------------------
What constitutes valid embargo terms is completely determined by the
EmbargoSetter implementation configured. It doesn't have to look anything like
a date. This makes it really difficult to do validation on the client side, as
suggested in #duraspace. See
https://wiki.duraspace.org/display/DSDOC/Embargo#Embargo-Embargomodelandlifecycle
> Nullpointer exception when bogus information is entered in the Embargo date
> field during submission
> ---------------------------------------------------------------------------------------------------
>
> Key: DS-672
> URL: https://jira.duraspace.org/browse/DS-672
> Project: DSpace
> Issue Type: Bug
> Components: XMLUI
> Affects Versions: 1.6.2
> Environment: The XMLUI on dspace.demo.org
> Reporter: Bram Luyten (@mire)
> Assignee: Mark H. Wood
>
> Under the submitter demo account I submitted an item in the Sample Items
> collection.
> I was able to enter something like "qsdf" in the embargo date field and
> proceed until the last step of the submission.
> When finishing the submission, following nullpointer is thrown:
> An error has occurred
> java.lang.NullPointerException:
> Cocoon stacktrace [show]
> Error calling continuation
> context:/resource://aspects/Submission/submission.js - 538:-1
> processPage
> context:/resource://aspects/Submission/submission.js - 474:-1
> doNextPage
> context:/resource://aspects/Submission/sitemap.xmap - 129:44 <map:call>
> context:/resource://aspects/Submission/sitemap.xmap - 128:61 <map:match>
> context:/resource://aspects/Submission/sitemap.xmap - 96:48 <map:select
> type="AuthenticatedSelector">
> context:/jndi:/localhost/xmlui/aspects/aspects.xmap - 119:72 <map:mount>
> context:/jndi:/localhost/xmlui/aspects/aspects.xmap - 109:34 <map:select
> type="parameter">
> context:/jndi:/localhost/xmlui/aspects/aspects.xmap - 108:36 <map:match
> type="AspectMatcher">
> context:/jndi:/localhost/xmlui/sitemap.xmap - 430:108 <map:mount>
> context:/jndi:/localhost/xmlui/sitemap.xmap - 429:53 <map:match>
> context:/resource://aspects/Statistics/sitemap.xmap - 70:31 <map:serialize
> type="xml">
> context:/resource://aspects/Statistics/sitemap.xmap - 38:55 <map:transform
> type="Navigation">
> context:/resource://aspects/Statistics/sitemap.xmap - 33:19 <map:generate>
> context:/jndi:/localhost/xmlui/aspects/aspects.xmap - 115:34 <map:serialize
> type="xml">
> context:/jndi:/localhost/xmlui/aspects/aspects.xmap - 114:43 <map:transform
> type="PageNotFound">
> context:/jndi:/localhost/xmlui/aspects/aspects.xmap - 113:22 <map:generate>
> context:/jndi:/localhost/xmlui/themes/Reference/sitemap.xmap - 184:62
> <map:serialize type="xhtml">
> context:/jndi:/localhost/xmlui/themes/Reference/sitemap.xmap - 181:112
> <map:transform type="NamespaceFilter">
> context:/jndi:/localhost/xmlui/themes/Reference/sitemap.xmap - 180:106
> <map:transform type="NamespaceFilter">
> context:/jndi:/localhost/xmlui/themes/Reference/sitemap.xmap - 174:68
> <map:transform type="i18n">
> context:/jndi:/localhost/xmlui/themes/Reference/sitemap.xmap - 170:72
> <map:transform>
> context:/jndi:/localhost/xmlui/themes/Reference/sitemap.xmap - 155:87
> <map:transform type="IncludePageMeta">
> context:/jndi:/localhost/xmlui/themes/Reference/sitemap.xmap - 131:83
> <map:generate type="file">
> context:/jndi:/localhost/xmlui/themes/Reference/sitemap.xmap - 128:49
> <map:match>
> context:/jndi:/localhost/xmlui/themes/themes.xmap - 63:45 <map:mount>
> context:/jndi:/localhost/xmlui/themes/themes.xmap - 62:35 <map:match
> type="ThemeMatcher">
> context:/jndi:/localhost/xmlui/sitemap.xmap - 550:94 <map:mount>
> Java stacktrace [hide]
> java.lang.NullPointerException
> at
> org.dspace.embargo.EmbargoManager.getEmbargoDate(EmbargoManager.java:166)
> at org.dspace.content.InstallItem.installItem(InstallItem.java:94)
> at org.dspace.content.InstallItem.installItem(InstallItem.java:71)
> at org.dspace.workflow.WorkflowManager.archive(WorkflowManager.java:660)
> at org.dspace.workflow.WorkflowManager.doState(WorkflowManager.java:614)
> at org.dspace.workflow.WorkflowManager.doState(WorkflowManager.java:590)
> at org.dspace.workflow.WorkflowManager.doState(WorkflowManager.java:554)
> at org.dspace.workflow.WorkflowManager.doState(WorkflowManager.java:514)
> at org.dspace.workflow.WorkflowManager.start(WorkflowManager.java:199)
> at
> org.dspace.submit.step.CompleteStep.doProcessing(CompleteStep.java:116)
> So either the submitter should be forced to either enter a correct date in
> the submission step, or the bogus embargo date should be thrown out upon
> archiving.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.duraspace.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
