[
https://jira.duraspace.org/browse/DS-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20424#action_20424
]
Robin Taylor commented on DS-724:
---------------------------------
Hi Andreas,
The patch looks sensible, however, I can't figure out when the error condition
would ever occur. Looking at the code it looks like createSubmitters() and
create createAdministrators() can only ever get called once. Did you have a
real world example or did you just notice that the code was inconsistent ?
Thanks, Robin.
> createAdministrators() and createSubmitters() should not add policies if the
> associated group already exists
> ------------------------------------------------------------------------------------------------------------
>
> Key: DS-724
> URL: https://jira.duraspace.org/browse/DS-724
> Project: DSpace
> Issue Type: Bug
> Components: DSpace API
> Affects Versions: 1.6.2
> Reporter: Andreas Schwander
> Assignee: Robin Taylor
> Attachments: Collection.patch
>
>
> New policies will be created when the methods createAdministrators() and
> createSubmitters() in org.dspace.content.Collection will be called even if
> the administrators or the submitters group already exists.
> These methods should just return the group if one exists and should not
> update the database or add policies.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.duraspace.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its
next-generation tools to help Windows* and Linux* C/C++ and Fortran
developers boost performance applications - including clusters.
http://p.sf.net/sfu/intel-dev2devmay
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
