[ 
https://jira.duraspace.org/browse/DS-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20485#action_20485
 ] 

Robin Taylor commented on DS-724:
---------------------------------

In conclusion, Andreas is correct in that the code is inconsistent. My own 
preference would be that if the groups already exist then the methods should 
throw an Exception if someone calls them, rather than returning the existing 
groups. If I'm feeling brave one day I'll make the change, but since the errors 
don't actually occur within the existing code I'll not rush into it. 

> createAdministrators() and createSubmitters() should not add policies if the 
> associated group already exists
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: DS-724
>                 URL: https://jira.duraspace.org/browse/DS-724
>             Project: DSpace
>          Issue Type: Bug
>          Components: DSpace API
>    Affects Versions: 1.6.2
>            Reporter: Andreas Schwander
>            Assignee: Robin Taylor
>         Attachments: Collection.patch
>
>
> New policies will be created when the methods createAdministrators() and 
> createSubmitters() in org.dspace.content.Collection will be called even if 
> the administrators or the submitters group already exists.
> These methods should just return the group if one exists and should not 
> update the database or add policies.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://jira.duraspace.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
vRanger cuts backup time in half-while increasing security.
With the market-leading solution for virtual backup and recovery, 
you get blazing-fast, flexible, and affordable data protection.
Download your free trial now. 
http://p.sf.net/sfu/quest-d2dcopy1
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to