Browse Pagination
-----------------

                 Key: DS-954
                 URL: https://jira.duraspace.org/browse/DS-954
             Project: DSpace
          Issue Type: Bug
          Components: DSpace API
    Affects Versions: 1.7.2
            Reporter: Dan Ishimitsu


The problem occurs when using Author or Subject browsing. Clicking on a linked 
"Starts With" letter at the top acts as expected. But then clicking on Next 
Page (or Previous Page) afterwards will sometimes return a different result 
than expect (ie the offset is wrong). You'll notice that the "total" # of 
authors/subjects changes if the problem exists.

I think this is caused because the "Starts With" locates its position in the 
list based on distinct sort_values. But clicking on the Next/Prev passes that 
position +/- offset, but uses a non-distinct list of sort_values. Ex. 
MacDonald, John and Macdonald, John will both result in sort_value = macdonald, 
john. So the distinct list counts it as 1, the non-distinct list counts it as 
2, and the offset is off by 1 when going to the next/prev page.

At the time of this writing, the problem exists on http://demo.dspace.org/xmlui 
if browsing by Author using starts with "C".

Changing BrowseEngine.java as follows fixes this issue, but may cause others.
412c412
<             dao.setDistinct(true);
---
>             dao.setDistinct(false); //Removed distinct
441c441
<             int total = getTotalResults(true);
---
>             int total = getTotalResults(false); //Removed distinct



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://jira.duraspace.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
AppSumo Presents a FREE Video for the SourceForge Community by Eric 
Ries, the creator of the Lean Startup Methodology on "Lean Startup 
Secrets Revealed." This video shows you how to validate your ideas, 
optimize your ideas and identify your business strategy.
http://p.sf.net/sfu/appsumosfdev2dev
_______________________________________________
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to