[
https://jira.duraspace.org/browse/DS-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=22384#comment-22384
]
Robin Taylor commented on DS-1019:
----------------------------------
Hi Peter,
This one is probably down to me. I moved the OAI config and rashly assumed that
it was only used with the OAI module. I changed all the references within the
OAI module to look in modules/oai-cfg but didn't check elsewhere. Probably the
right thing to do is to the change the XMLUI code to look in modules since that
is what has been done for all the other config changes. Feel free to assign to
me or make the change yourself if you feel inclined.
Cheers, Robin.
> Update code usages of ConfigurationManager.getProperty to reflect changes in
> config/modules
> -------------------------------------------------------------------------------------------
>
> Key: DS-1019
> URL: https://jira.duraspace.org/browse/DS-1019
> Project: DSpace
> Issue Type: Bug
> Components: OAI-PMH
> Affects Versions: 1.8.0
> Reporter: Peter Dietz
> Priority: Major
>
> I noticed that rearranging the config files from dspace.cfg to
> modules/feature.cfg that the Java source code that wanted the configuration
> property has never been updated to reflect the changes.
> I've noticed one module in particular that has not yet been updated, and is
> now broken as a result.
> The broken feature would be OAI Harvest for Collections.
> https://github.com/DSpace/DSpace/blob/14f3d7213af360ccd608c951ede5fac560bbc9a0/dspace-xmlui/dspace-xmlui-api/src/main/java/org/dspace/app/xmlui/aspect/administrative/collection/EditCollectionHarvestingForm.java#L134
> {noformat}
> String key = "harvester.oai.metadataformats." + metadataFormatValue;
> String metadataString = ConfigurationManager.getProperty(key);
> {noformat}
> The configuration property harvester.oai.metadataformats.* used to exist in
> dspace.cfg, however, they now reside in modules/oai.cfg. The default
> ConfigurationManager.getProperty(key) is only searching in dspace.cfg for
> these config properties. We either need to fix the code of all the affected
> modules, or update the default behavior of getProperty(key) to also look in
> modules/*.cfg for the field.
> https://github.com/DSpace/DSpace/blob/14f3d7213af360ccd608c951ede5fac560bbc9a0/dspace/config/modules/oai.cfg#L38
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.duraspace.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA
Learn about the latest advances in developing for the
BlackBerry® mobile platform with sessions, labs & more.
See new tools and technologies. Register for BlackBerry® DevCon today!
http://p.sf.net/sfu/rim-devcon-copy1
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
