[ 
https://jira.duraspace.org/browse/DS-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robin Taylor updated DS-1019:
-----------------------------

    Assignee: Robin Taylor
      Status: Open  (was: Received)
    
> Update code usages of ConfigurationManager.getProperty to reflect changes in 
> config/modules
> -------------------------------------------------------------------------------------------
>
>                 Key: DS-1019
>                 URL: https://jira.duraspace.org/browse/DS-1019
>             Project: DSpace
>          Issue Type: Bug
>          Components: OAI-PMH
>    Affects Versions: 1.8.0
>            Reporter: Peter Dietz
>            Assignee: Robin Taylor
>            Priority: Major
>
> I noticed that rearranging the config files from dspace.cfg to 
> modules/feature.cfg that the Java source code that wanted the configuration 
> property has never been updated to reflect the changes.
> I've noticed one module in particular that has not yet been updated, and is 
> now broken as a result.
> The broken feature would be OAI Harvest for Collections.
> https://github.com/DSpace/DSpace/blob/14f3d7213af360ccd608c951ede5fac560bbc9a0/dspace-xmlui/dspace-xmlui-api/src/main/java/org/dspace/app/xmlui/aspect/administrative/collection/EditCollectionHarvestingForm.java#L134
> {noformat}
>           String key = "harvester.oai.metadataformats." + metadataFormatValue;
>           String metadataString = ConfigurationManager.getProperty(key);
> {noformat}
> The configuration property harvester.oai.metadataformats.* used to exist in 
> dspace.cfg, however, they now reside in modules/oai.cfg. The default 
> ConfigurationManager.getProperty(key) is only searching in dspace.cfg for 
> these config properties. We either need to fix the code of all the affected 
> modules, or update the default behavior of getProperty(key) to also look in 
> modules/*.cfg for the field.
> https://github.com/DSpace/DSpace/blob/14f3d7213af360ccd608c951ede5fac560bbc9a0/dspace/config/modules/oai.cfg#L38

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.duraspace.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2d-oct
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to