[ 
https://jira.duraspace.org/browse/DS-1202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=25304#comment-25304
 ] 

Ivan Masár edited comment on DS-1202 at 6/26/12 12:03 PM:
----------------------------------------------------------

I did some very basic testing and here are my notes:

* The attached addon cleanly applies to 1.8.2 using the provided script. It 
fails to apply to git HEAD because of commit 
eacbec71740f719b763cf7d5033e9f2777e02cd2
* It requires the following options in dspace.cfg (This is not mentioned in the 
manual. I recomment to make a [dspace-src]/dspace/config/modules/xoai.cfg file 
with these options part of the xoai addon instead of putting more options into 
dspace.cfg.)
xoai.solr.url = http://localhost:8080/solr/xoai
xoai.baseUrl = ${dspace.baseUrl}
xoai.tmp.dir = # I don't know what to put here, but it worked fine without it
* The xoai-import fails with a "java.net.MalformedURLException" error if the 
"xoai.solr.url" option is not present. It would be more user-friendly to catch 
this error and display a warning about missing config option.
* if xoai.baseUrl wasn't set, xoai responses returned
  <request verb="ListSets">
    null/request
  </request>
instead of
  <request verb="ListSets">
    http://example.com/oai/request
  </request>
couldn't XOAI use dspace.baseUrl instead of xoai.baseUrl? XOAI should fail with 
a warning if the required configuration options are not set.
* The "[dspace]/bin/xoai-import" script should be available as 
"[dspace]/bin/dspace xoai-import" instead.
* xoai-import should log an INFO when it started and finished
* xoai-import could display statistics how long it took (IIRC index-init, 
index-update and update-discovery-index do this)
* I noticed the xoai responses don't declare the "xsi" schema, which the old 
oai interface did (I'm not implying that this is a problem).
* Declare a BSD license in file headers and in maven artifacts metadata
* I don't know if this is important (other developers should say), but maybe 
you should use org.dspace.xoai in package names instead of com.lyncode.xoai

I'll continue testing. It looks very good so far! The speed is amazing, for me 
about 10x faster than the oai webapp.
                
      was (Author: helix84):
    I did some very basic testing and here are my notes:

* The attached addon cleanly applies to 1.8.2 using the provided script. It 
fails to apply to git HEAD because of commit 
eacbec71740f719b763cf7d5033e9f2777e02cd2
* It requires the following options in dspace.cfg (This is not mentioned in the 
manual. There should be a [dspace-src]/dspace/config/modules/xoai.cfg file 
present with these options.)
xoai.solr.url = http://localhost:8080/solr/xoai
xoai.baseUrl = ${dspace.baseUrl}
xoai.tmp.dir = # I don't know what to put here, but it worked fine without it
* The xoai-import fails with a "java.net.MalformedURLException" error if the 
"xoai.solr.url" option is not present. It would be more user-friendly to catch 
this error and display a warning about missing config option.
* if xoai.baseUrl wasn't set, xoai responses returned
  <request verb="ListSets">
    null/request
  </request>
instead of
  <request verb="ListSets">
    http://example.com/oai/request
  </request>
couldn't XOAI use dspace.baseUrl instead of xoai.baseUrl? XOAI should fail with 
a warning if the required configuration options are not set.
* The "[dspace]/bin/xoai-import" script should be available as 
"[dspace]/bin/dspace xoai-import" instead.
* xoai-import should log an INFO when it started and finished
* xoai-import could display statistics how long it took (IIRC index-init, 
index-update and update-discovery-index do this)
* I noticed the xoai responses don't declare the "xsi" schema, which the old 
oai interface did (I'm not implying that this is a problem).
* Declare a BSD license in file headers and in maven artifacts metadata
* I don't know if this is important (other developers should say), but maybe 
you should use org.dspace.xoai in package names instead of com.lyncode.xoai

I'll continue testing. It looks very good so far! The speed is amazing, for me 
about 10x faster than the oai webapp.
                  
> DSpace XOAI Data Provider
> -------------------------
>
>                 Key: DS-1202
>                 URL: https://jira.duraspace.org/browse/DS-1202
>             Project: DSpace
>          Issue Type: New Feature
>          Components: OAI-PMH
>            Reporter: DSpace @ Lyncode
>            Priority: Major
>              Labels: oai
>         Attachments: DSpace XOAI.zip, XOAI Manual.pdf
>
>
> DSpace XOAI Data Provider is an OAI-PMH Interface for DSpace based upon XOAI 
> (OAI-PMH java toolkit). With the following characteristics:
> - OpenAIRE compliant
> - Driver compliant
> - Default context (same behavior as the original DSpace OAI interface)
> - Completely configurable
> - Fast (based on solr, also with cache)
> - Extendable

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.duraspace.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to