[ 
https://jira.duraspace.org/browse/DS-1202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=25309#comment-25309
 ] 

DSpace @ Lyncode commented on DS-1202:
--------------------------------------

Firstly, thanks for your comments Ivan. There are some issues related with 
DSpace coding patterns and already existent mechanisms that, in fact, i didn't 
follow/use. Anyway, i'll work on that, as so, thanks for your comments Ivan. As 
soon as possible i'll do a git pull request with all changes (is that easy for 
you to test?).

Most of the answers are related with our own development policies. We spent 
much effort to avoid using DSpace native components, using (and developing) our 
own, as so we could easily migrate our solutions without having much 
dependencies on DSpace native modules (they could change).

* It requires the following options in dspace.cfg (This is not mentioned in the 
manual. I recommend to make a [dspace-src]/dspace/config/modules/xoai.cfg file 
with these options part of the xoai addon instead of putting more options into 
dspace.cfg.) 
xoai.solr.url = http://localhost:8080/solr/xoai 
xoai.baseUrl = ${dspace.baseUrl} 
xoai.tmp.dir = # I don't know what to put here, but it worked fine without it 

Ok i'll make that structural change. The xoai.tmp.dir is required for caching 
mechanism, i was thinking about to modify xoai to use the DSpace caching 
mechanism, but before i have some questions related with the caching mechanism:

> If i need to cache larges amount of data (+GBytes) in a persistent way (it 
> will be more efficient), should i avoid the use of core cache service?

* The xoai-import fails with a "java.net.MalformedURLException" error if the 
"xoai.solr.url" option is not present. It would be more user-friendly to catch 
this error and display a warning about missing config option. 

Ok.

* if xoai.baseUrl wasn't set, xoai responses returned 
  <request verb="ListSets"> 
    null/request 
  </request> 
instead of 
  <request verb="ListSets"> 
    http://example.com/oai/request 
  </request> 
couldn't XOAI use dspace.baseUrl instead of xoai.baseUrl? XOAI should fail with 
a warning if the required configuration options are not set. 

I'll use the dspace.baseUrl and dynamically get the webapp context.

* The "[dspace]/bin/xoai-import" script should be available as 
"[dspace]/bin/dspace xoai-import" instead. 

As i said, it was an implementation policy. I'll work on that.

* xoai-import should log an INFO when it started and finished

Ok

* xoai-import could display statistics how long it took (IIRC index-init, 
index-update and update-discovery-index do this) 

Yes. Nice and easy to develop feature.

* I noticed the xoai responses don't declare the "xsi" schema, which the old 
oai interface did (I'm not implying that this is a problem). 

This is a detail. But could be useful to use dynamic XML validators.

* Declare a BSD license in file headers and in maven artifacts metadata

Ok

* I don't know if this is important (other developers should say), but maybe 
you should use org.dspace.xoai in package names instead of com.lyncode.xoai 

Ok

* How do I force a cached result to be purged? I know that running xoai-import 
does it (which should be documented), but is there no parameter in the web 
interface? 

The only way to do that is with xoai-import. How important would be to add this 
feature?

* I also have a design question - why was a spearate Solr core required? 
Couldn't the existing "search" core be used with some modifications?

Old development policies. I'm about to change that.

* Could you please provide a configuration option to set a XSLT stylesheet for 
the responses? It's just a link to the XSL file which is supposed to be applied 
client-side.

Yes. Nice and easy!
                
> DSpace XOAI Data Provider
> -------------------------
>
>                 Key: DS-1202
>                 URL: https://jira.duraspace.org/browse/DS-1202
>             Project: DSpace
>          Issue Type: New Feature
>          Components: OAI-PMH
>            Reporter: DSpace @ Lyncode
>            Priority: Major
>              Labels: oai
>         Attachments: DSpace XOAI.zip, XOAI Manual.pdf
>
>
> DSpace XOAI Data Provider is an OAI-PMH Interface for DSpace based upon XOAI 
> (OAI-PMH java toolkit). With the following characteristics:
> - OpenAIRE compliant
> - Driver compliant
> - Default context (same behavior as the original DSpace OAI interface)
> - Completely configurable
> - Fast (based on solr, also with cache)
> - Extendable

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.duraspace.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to