Robin Taylor created DS-1527:
--------------------------------

             Summary: Memory leak in CachingService
                 Key: DS-1527
                 URL: https://jira.duraspace.org/browse/DS-1527
             Project: DSpace
          Issue Type: Bug
          Components: Service Manager
    Affects Versions: 3.1, 3.0, 1.8.2, 1.8.1, 1.8.0
            Reporter: Robin Taylor
            Priority: Major
             Fix For: 4.0


CachingServiceImpl contains a memory leak, or to be more precise the nested 
class CachingServiceRequestInterceptor does. If you want to confirm this then 
use a profiler and watch map 'requestCachesMap' grow, or use the 'old school' 
method and stick some debugging code in the 
onStart() method. The onStart() method and its partner onEnd() are invoked 
indirectly by DSpaceWebappServletFilter, however, it appears onEnd() does not 
get invoked for requests of type FORWARD or INCLUDE. This results in lots of 
undeleted entries in requestCachesMap.

Ideally it would be good to understand why onEnd() does not get invoked for all 
request types. However, if nobody can come up with an explanation then the easy 
fix for this is to delete the references to FORWARD and INCLUDE in the filter 
mapping definition in web.xml. If nobody can think of a reason not to do so 
I'll provide a pull request to that effect.

Cheers, Robin.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

------------------------------------------------------------------------------
Own the Future-Intel® Level Up Game Demo Contest 2013
Rise to greatness in Intel's independent game demo contest.
Compete for recognition, cash, and the chance to get your game 
on Steam. $5K grand prize plus 10 genre and skill prizes. 
Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d
_______________________________________________
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to