[
https://jira.duraspace.org/browse/DS-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robin Taylor closed DS-1527.
----------------------------
Resolution: Fixed
Merged pull request to 3.2 branch and master. Made a bit of a meal of it due to
my rudimentary knowledge of Git, so the pull requests were actually completely
separate and with different comments.
> Memory leak in CachingService
> -----------------------------
>
> Key: DS-1527
> URL: https://jira.duraspace.org/browse/DS-1527
> Project: DSpace
> Issue Type: Bug
> Components: Service Manager
> Affects Versions: 1.8.0, 1.8.1, 1.8.2, 3.0, 3.1
> Reporter: Robin Taylor
> Assignee: Robin Taylor
> Priority: Major
> Fix For: 3.2, 4.0
>
> Attachments: memory-year.png
>
>
> CachingServiceImpl contains a memory leak, or to be more precise the nested
> class CachingServiceRequestInterceptor does. If you want to confirm this then
> use a profiler and watch map 'requestCachesMap' grow, or use the 'old school'
> method and stick some debugging code in the
> onStart() method. The onStart() method and its partner onEnd() are invoked
> indirectly by DSpaceWebappServletFilter, however, it appears onEnd() does not
> get invoked for requests of type FORWARD or INCLUDE. This results in lots of
> undeleted entries in requestCachesMap.
> Ideally it would be good to understand why onEnd() does not get invoked for
> all request types. However, if nobody can come up with an explanation then
> the easy fix for this is to delete the references to FORWARD and INCLUDE in
> the filter mapping definition in web.xml. If nobody can think of a reason not
> to do so I'll provide a pull request to that effect.
> Cheers, Robin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel
