[ 
https://jira.duraspace.org/browse/DS-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=28088#comment-28088
 ] 

Tim Donohue commented on DS-1550:
---------------------------------

Quick question:

Not sure I understand the logic of making the "dspace-lni-client" a top-level 
project (i.e. moving it to [src]/dspace-lni-client/ from its location at 
[src]/dspace-lni/dspace-lni-client/).   Just noticing that during the Maven 
Consolidation work, we specifically tried to minimize the number of top-level 
projects (and projects overall).  

For example the "dspace-sword-client" was actually merged into "dspace-xmlui" 
(as it was XMLUI specific).  It no longer exists as a standalone project.

I guess I was wondering why move the "dspace-lni-client" codebase from its 
existing location?  Couldn't we just "tie it back in" by having "dspace-lni" 
load and build the "dspace-lni-client" project (which conceptually seems like a 
small dspace-lni/pom.xml change)?
                
> dspace-lni-client is detached from the project tree and won't build
> -------------------------------------------------------------------
>
>                 Key: DS-1550
>                 URL: https://jira.duraspace.org/browse/DS-1550
>             Project: DSpace
>          Issue Type: Bug
>          Components: LNI
>            Reporter: Mark H. Wood
>            Assignee: Mark H. Wood
>              Labels: has-pull-request
>
> Building from the root or from dspace-lni does not even attempt to build 
> dspace-lni-client.  Building in dspace-lni/dspace-lni-client causes Maven to 
> complain that the parent POM can't be resolved and the parent path is wrong.  
> NetBeans throws "caution" triangles on dspace-lni-client and 
> modules/dspace-lni.  It looks to me as though dspace-lni-client was (half?) 
> missed when the project tree was flattened.
> It seems to me that dspace-lni-client should be moved up alongside dspace-lni 
> (server) and its parentage corrected.  This would follow the example of 
> dspace-sword and dspace-sword-client.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/alienvault_d2d
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to