[ 
https://jira.duraspace.org/browse/DS-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=28091#comment-28091
 ] 

Tim Donohue commented on DS-1550:
---------------------------------

Mark, 

I definitely understand the concerns about "deeply nested" projects. 

But, for now, I think keeping the "dspace-lni-client" where it is may be our 
best option.  If we did move it to the [src]/dspace-lni-client location, it 
begins to live "separate" from the main "dspace-lni" project. This may cause 
problems if (for example) you were to disable LNI from building locally (e.g. 
mvn -P !dspace-lni package).  If the "dspace-lni-client" is a separate project, 
it will not respect that command & may actually throw errors as the LNI was 
disabled from building.

(Sidenote: Ideally, at some point, we may want to just move both LNI projects 
out into a separate GitHub project altogether.  I'm not convinced they are very 
widely used to this day, and it seems like they could be maintained in parallel 
& just updated by those who use them.)

But, for the time being, I think my Pull #126 is our best option to just get 
things compiling/working.
                
> dspace-lni-client is detached from the project tree and won't build
> -------------------------------------------------------------------
>
>                 Key: DS-1550
>                 URL: https://jira.duraspace.org/browse/DS-1550
>             Project: DSpace
>          Issue Type: Bug
>          Components: LNI
>            Reporter: Mark H. Wood
>            Assignee: Mark H. Wood
>              Labels: has-pull-request
>
> Building from the root or from dspace-lni does not even attempt to build 
> dspace-lni-client.  Building in dspace-lni/dspace-lni-client causes Maven to 
> complain that the parent POM can't be resolved and the parent path is wrong.  
> NetBeans throws "caution" triangles on dspace-lni-client and 
> modules/dspace-lni.  It looks to me as though dspace-lni-client was (half?) 
> missed when the project tree was flattened.
> It seems to me that dspace-lni-client should be moved up alongside dspace-lni 
> (server) and its parentage corrected.  This would follow the example of 
> dspace-sword and dspace-sword-client.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/alienvault_d2d
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to