Title: Message Title
|
|
|
|
from my recollection, and the looks of things on this Jira ticket (under the commits tab) only one change was merged to Master (b8fce4800e5a537e8d9cffb7ef73bee53a0de55b), it wasn't ever merged to 3.x. So, we'd need to backport this to 3.x. We don't typically backport bug fixes, but you're welcome to do so. I think if you want to re-open that's fine, if it's broken on master it needs fixing, and this should never have been closed. If it's actually fixed on master, and you just want to refactor the code, you should probably open a new ticket for the refactoring work.
Let me say that I'm glad someone noticed the code, I felt a bit goofy about copying the existing loop logic from the shib plugin, but figured if I was going to invest any time in refactoring authN/Z, I was going to get serious about it, and replace the whole works with something better. If that's an idea that appeals to you, you're more than welcome to join the effort. More info here: http://tinyurl.com/dspace-replace-auth
|
|
|
|
|
|
|
|
When Shibboleth returns multiple values for a header, such as SHIB-SCOPED-AFFILIATION, it delimits the values with semicolons. The code in org.dspace.authenticate.ShibAuthentication.findMultipleHeaders does not correctly handle such values, due to a minor logic error. I have a patch which I have confirmed fixes this issue (thanks to Mark Wood for his help...
|
|
|
|
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel
