OK, understood. On monday we will review the "unmergeable" code. Expect some questions, since we are not very familiar with Code Contribution Guidelines thanks
Emilio El 18/10/2013 17:49, Tim Donohue escribió: > Hi All, > > It looks like the delay on this "Request a Copy" feature is that we > currently don't have a (mergeable) GitHub Pull Request to review & > accept into the DSpace codebase. > > As Emilio noted, there are three (interlinked) tickets open: > https://jira.duraspace.org/browse/DS-830 > https://jira.duraspace.org/browse/DS-1585 > https://jira.duraspace.org/browse/DS-824 > > However, as of today, we only have a single Pull Request (created by > Emilio for the XMLUI version only), and unfortunately it is currently > in an "unmergeable" state (it has code conflicts which need resolving, > see the comments): > > https://github.com/DSpace/DSpace/pull/260 > > Per our DSpace Code Contribution Guidelines, the DSpace Committers > highly recommend submitting new features as a GitHub Pull Request: > > https://wiki.duraspace.org/display/DSPACE/Code+Contribution+Guidelines > > To try and clarify even further: > * Submitting code contributions via a GitHub Pull Request means that > it will be reviewed more quickly and is much more likely to be > accepted as part of the next release of DSpace. > * Without a Pull Request, the code review is more likely to be > delayed, as the Committers will need to locate a volunteer to > "steward" your code and create the Pull Request on your behalf. > > This all being said, it sounds like the DSpace 4.0 Release Team (in > conjunction with the Committers) is making an effort to see if this > "Request a Copy" feature can still be added into the upcoming DSpace > 4.0 release (even though our advertised Pull Request deadline for 4.0 > was back on Oct 7). There's no guarantee it'll make it into 4.0, but > we'll see what we can reasonably do. > > I hope this helps to clarify the status of these tickets. I think the > Committers would love to see this feature in DSpace. But the reality > seems to be that we haven't found the volunteer(s) to generate the > Pull Request(s) that are needed to kickstart the process. (Emilio is > already chipping in, and we thank him for that, but we just need to > get his PR fixed so it can be merged.) > > If there are further questions, please feel free to ask. We'd be glad > to explain further as needed. > > - Tim > ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk _______________________________________________ Dspace-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dspace-general
