On May 18, 2016, at 12:33 PM, Terry Brady <[email protected]
<mailto:[email protected]>> wrote:
Tim,
Thanks for the explanation.
To implement #1, I recommend that we add the necessary hibernate
configuration logic to recursively traverse community2community. Who
could advise on that change?
To implement #2, we would probably want to change the method return
type to return a list of lists: one list for each immediate community
parent.
Terry
On Wed, May 18, 2016 at 7:39 AM, Tim Donohue <[email protected]
<mailto:[email protected]>> wrote:
Hi Terry,
Some quick answers...
I'm not sure of the correct answer to #1 myself (Peter Dietz, did
you create this behavior?). Since it's called a "List" though, it
sounds to me like the behavior in DSpace 5.x is more correct
(that the intension may be to locate the full location of the
collection, similar to breadcrumbs).
As for #2, the API / database has always supported the "idea" of
a Collection existing in multiple locations (i.e. a "linked"
Collection). However, we've never found a reason to fully build
this out with unit tests, etc. So, it's a partially created
concept, and it's never really been proven to "work". In
addition, the UIs have never supported this idea...at the UI
level, a Collection only ever belongs to a single Community.
So, essentially, #2 would/should be treated as a new feature. The
groundwork is there in the API / database layer. But, it has
never been fully built out. It'd need a volunteer to dig in and
implement this concept so that it's actually usable in the UIs.
It also may require some refactoring at the REST API layer, as
you've noted.
- Tim
On 5/17/2016 1:03 PM, Terry Brady wrote:
I am investigating the following ticket:
https://jira.duraspace.org/browse/DS-2766
Here are my questions.
1. In the collections endpoint, of the REST api, what is the
intended behavior of expand=parentCommunityList?
2. In DSpace, can a collection exist in multiple communities?
Question 1. expand=parentCommunityList
In DSpace5x, the expand=parentCommunityList option returns the
full hierarchy of owing communities for a collection (all the
way to the top level community).
In DSpace 6x, this option returns the subcommunity that is an
immediate parent of the collection.
Assuming that this behavior is incorrect in DSpace 6, the
following configuration will need to be updated to follow the
community2community hierarchy:
https://github.com/DSpace/DSpace/blob/master/dspace-api/src/main/java/org/dspace/content/Collection.java#L81-L86
Question 2: Can a collection exist in multiple communities?
The following method in DSpace 5x could imply that a collection
can exist in multiple communities:
https://github.com/DSpace/DSpace/blob/dspace-5_x/dspace-api/src/main/java/org/dspace/content/Collection.java#L1402
But, the REST API implies that there is a single "parentCommunity".
https://github.com/DSpace/DSpace/blob/dspace-5_x/dspace-rest/src/main/java/org/dspace/rest/common/Collection.java#L136
and a separate parentCommunityList
https://github.com/DSpace/DSpace/blob/dspace-5_x/dspace-rest/src/main/java/org/dspace/rest/common/Collection.java#L156
What is the intended set of relationships to be supported?
If a collection can exist in multiple communities, how should
the REST api respond to "expand=parentCommunityList" option?
If a collection can exist in multiple communities, how can this
relationship be created in our UIs?
Terry
--
Terry Brady
Applications Programmer Analyst
Georgetown University Library Information Technology
https://www.library.georgetown.edu/lit/code
425-298-5498 <tel:425-298-5498> (Seattle, WA)
--
You received this message because you are subscribed to the
Google Groups "DSpace Technical Support" group.
To unsubscribe from this group and stop receiving emails from
it, send an email to [email protected]
<mailto:[email protected]>.
To post to this group, send email to
[email protected] <mailto:[email protected]>.
Visit this group at https://groups.google.com/group/dspace-tech.
For more options, visit https://groups.google.com/d/optout.
--
Tim Donohue
Technical Lead for DSpace & DSpaceDirect
DuraSpace.org <http://DuraSpace.org> |DSpace.org <http://DSpace.org>
|DSpaceDirect.org <http://DSpaceDirect.org>
--
You received this message because you are subscribed to the
Google Groups "DSpace Technical Support" group.
To unsubscribe from this group and stop receiving emails from it,
send an email to [email protected]
<mailto:[email protected]>.
To post to this group, send email to [email protected]
<mailto:[email protected]>.
Visit this group at https://groups.google.com/group/dspace-tech.
For more options, visit https://groups.google.com/d/optout.
--
Terry Brady
Applications Programmer Analyst
Georgetown University Library Information Technology
https://www.library.georgetown.edu/lit/code
425-298-5498 (Seattle, WA)
--
You received this message because you are subscribed to the Google
Groups "DSpace Technical Support" group.
To unsubscribe from this group and stop receiving emails from it,
send an email to [email protected]
<mailto:[email protected]>.
To post to this group, send email to [email protected]
<mailto:[email protected]>.
Visit this group at https://groups.google.com/group/dspace-tech.
For more options, visit https://groups.google.com/d/optout.