Great. I've left a comment in DS-3999 stating that it appears to correct the issue.
- Darryl On Thursday, September 20, 2018 at 3:26:06 PM UTC-6, Tim Donohue wrote: > > Hi Darryl, > > We welcome *either* code reviewers or testers. So, simply adding your > feedback that the PR "worked for you" and resolved ____ issues is good > feedback. If you don't have a GitHub account, you can also just add your > testing feedback to the original JIRA ticket ( > https://jira.duraspace.org/browse/DS-3999). > > Definitely don't worry if you cannot provide a code review. We have > plenty of volunteers that can provide quick code reviews. Often we are > most lacking in good *testers* (especially folks who've seen the issue & > know how to trigger it, and can therefore easily tell if the code "fixes > it"). > > Thanks for your testing! > > Tim > > > > > On Thu, Sep 20, 2018 at 4:21 PM Darryl Friesen <[email protected] > <javascript:>> wrote: > >> >> I implemented the change to Orcidv2AuthorityValue.java as per PR 2195 >> and rolled that out to our test server. This seems to have fixed most >> (all?) of the issues mentioned in this thread, specifically: >> >> >> - adding an additional author no longer seems to remove orcid_id from >> the Solr database >> - Running index-authority also no longer removes orcid_id from Solr >> - orcid is now displayed when using the author Lookup feature. This >> is an important issue for us (and Sean as well i assume since he also >> mentioned it) we prefer ORCID whenever possible. This will help >> eliminate >> dups in authority control now that people can see the ORCID ID again >> >> I did not try UpdateAuthorities to see if the issues mentioned by Sean >> were still an issue. >> >> Tim, I'm not a Java programmer -- I can help out if you want to migrate >> DSpace to one of the PHP frameworks though :) -- so I don't feel >> comfortable making an approving review of the code in the PR; I'm not sure >> if the code in that PR is "good" or not, nor how it might affect the rest >> of the DSpace codebase, but I could leave a comment in the PR if that >> helps. It *seems* to have fixed a lot of issues for me. >> >> - Darryl >> >> >> >> >> >> On Thursday, September 20, 2018 at 12:42:54 PM UTC-6, Tim Donohue wrote: >> >>> All, >>> >>> For anyone affected by the index-authority bug described in >>> https://jira.duraspace.org/browse/DS-3999, we could use more testers >>> for the proposed fix at: https://github.com/DSpace/DSpace/pull/2195 . >>> The quicker bug fixes get tested or reviewed, the quicker we are able to >>> move them along into the actual codebase. While we do have some volunteers >>> that help us with testing/reviewing, finding additional community users can >>> always speed up the process. >>> >>> - Tim >>> >>> On Thu, Sep 20, 2018 at 1:12 PM Sean Kalynuk <[email protected]> >>> wrote: >>> >> Hi Darryl, >>>> >>>> >>>> >>>> I’m currently experimenting with DSpace 6.3 and have the same or >>>> similar issues. >>>> >>>> >>>> >>>> · index-authority is removing orcid_id but leaving the >>>> authority_type as “orcid” (see >>>> https://jira.duraspace.org/browse/DS-3999) >>>> >>>> · The orcid_id is not displaying in the Author Lookup for >>>> authors added from ORCID, so, when there are duplicate author entries, you >>>> cannot differentiate authority_type=”orcid_id” from >>>> authority_type=”person” >>>> for the same person >>>> >>>> · UpdateAuthorities has multiple issues (-i option results in >>>> NPE and a full update only runs on 10 records) (see >>>> https://jira.duraspace.org/browse/DS-3302) >>>> >>>> >>>> >>>> -- >>>> >>>> Sean >>>> >>>> >>>> >>> *From:* [email protected] <[email protected]> *On >>>> Behalf Of *Darryl Friesen >>>> >>> >>>> *Sent:* September 20, 2018 11:18 AM >>>> >>> *To:* DSpace Technical Support <[email protected]> >>>> >>> >>>> *Subject:* [dspace-tech] Re: Problems with Orcid in dspace 6.3 >>>> >>> >>>> >>>> While I haven't experimented with what happens when adding additional >>>> authors, I've noticed that the "orcid_id" field also seems to get >>>> removed by the "index-authority" job that runs as part of cron. Perhaps >>>> there's a common task that is executed during both processes that is >>>> messing up the Solr database. >>>> >>>> >>>> >>>> I've also noticed issues with the authority control/ORCID Lookup >>>> features during submission (and when editing). The OCRID seems to be lost >>>> there too, and the authority control will happily create duplicates. I >>>> posted about it a couple weeks ago: >>>> >>>> >>>> >>>> >>>> https://groups.google.com/d/msg/dspace-tech/4nJRVyn8Hk8/M0TnMAIBCgAJ >>>> >>>> >>>> >>>> I'm happy the ORCID lookup works again, but there seems to be some >>>> issues with it. >>>> >>>> >>>> >>>> - Darryl >>>> >>>> >>>> >>>> On Sunday, September 16, 2018 at 3:37:20 AM UTC-6, Stefanie Behnke >>>> wrote: >>>> >>>> Dear all, >>>> >>>> we use Dspace 6.3, XMLUI Interface and ORCID enabled. >>>> >>>> Submitting a new item with 2 authors works. The result in the authority >>>> shows: (example for one author) >>>> >>>> { >>>> >>>> "id": "75e2dd03-7cdf-4e21-9b1d-293f02d3c0cf", >>>> >>>> "field": "dc_contributor_author", >>>> >>>> "value": "Behnke, Stefanie", >>>> >>>> "deleted": false, >>>> >>>> "creation_date": "2018-09-16T09:01:40.474Z", >>>> >>>> "last_modified_date": "2018-09-16T09:01:40.474Z", >>>> >>>> "authority_type": "orcid", >>>> >>>> "first_name": "Stefanie", >>>> >>>> "last_name": "Behnke", >>>> >>>> "orcid_id": "0000-0001-5923-423X" >>>> >>>> }, >>>> >>>> >>>> >>>> Trying to add a third author with ORCID to this item make the >>>> “orcid_id” for the existing authors vanish from the authority: >>>> >>>> { >>>> >>>> "id": "75e2dd03-7cdf-4e21-9b1d-293f02d3c0cf", >>>> >>>> "field": "dc_contributor_author", >>>> >>>> "value": "Behnke, Stefanie", >>>> >>>> "deleted": false, >>>> >>>> "creation_date": "2018-09-16T09:01:40.474Z", >>>> >>>> "last_modified_date": "2018-09-16T09:01:40.474Z", >>>> >>>> "authority_type": "orcid", >>>> >>>> "first_name": "Stefanie", >>>> >>>> "last_name": "Behnke" >>>> >>>> }, >>>> >>>> >>>> >>>> I cannot imagine that this should be the intended behaviour, so I think >>>> this is a bug. >>>> >>>> Any help is much appreciated. >>>> >>>> Best regards >>>> >>>> Stefanie >>>> >>>> -- >>>> All messages to this mailing list should adhere to the DuraSpace Code >>>> of Conduct: https://duraspace.org/about/policies/code-of-conduct/ >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "DSpace Technical Support" group. >>>> >>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To post to this group, send email to [email protected]. >>>> >>> >>>> Visit this group at https://groups.google.com/group/dspace-tech. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> -- >>>> All messages to this mailing list should adhere to the DuraSpace Code >>>> of Conduct: https://duraspace.org/about/policies/code-of-conduct/ >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "DSpace Technical Support" group. >>>> >>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To post to this group, send email to [email protected]. >>> >>> >>>> Visit this group at https://groups.google.com/group/dspace-tech. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> -- >>> Tim Donohue >>> Technical Lead for DSpace & DSpaceDirect >>> DuraSpace.org | DSpace.org | DSpaceDirect.org >>> >> -- >> All messages to this mailing list should adhere to the DuraSpace Code of >> Conduct: https://duraspace.org/about/policies/code-of-conduct/ >> --- >> You received this message because you are subscribed to the Google Groups >> "DSpace Technical Support" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> To post to this group, send email to [email protected] >> <javascript:>. >> Visit this group at https://groups.google.com/group/dspace-tech. >> For more options, visit https://groups.google.com/d/optout. >> > -- > Tim Donohue > Technical Lead for DSpace & DSpaceDirect > DuraSpace.org | DSpace.org | DSpaceDirect.org > -- All messages to this mailing list should adhere to the DuraSpace Code of Conduct: https://duraspace.org/about/policies/code-of-conduct/ --- You received this message because you are subscribed to the Google Groups "DSpace Technical Support" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/dspace-tech. For more options, visit https://groups.google.com/d/optout.
