Hi Mark,
I had seen this patch, however I wasn't aware about the use of a temp directory
- probably because it was added as a later comment ;-)
However, it does not resolve any of the issues that we've been discussing:
1) No changes to the DSQuery object means that existing IndexSearcher objects
are still not close()d correctly - you are still reliant on the garbage
collector to finalize the object.
2) You are still opening the index in 'search.dir' with wipe_existing set to
true to swap the new index in. Under Windows, this will trash the index if
there is an existing IndexSearcher open against that index (which there more
than likely will be).
3) Without a ContextListener to close the DSQuery's IndexSearcher, when
redeploying/reloading the application you will most likely have an
IndexSearcher floating around that can only be removed by stopping Tomcat.
Under Windows, that means you will have to stop Tomcat to do anything with the
'search.dir' index.
Obviously, your patch addresses other issues in IndexWriter, is a distinct
improvement for anyone that doesn't have an issue with IndexSearcher causing
file system locks, and may help Jose's problem (there is some ambiguity in
where the memory leak is occurring, and what is meant by the DSpace instance
'going down').
But it won't fix the issues that are seen under Windows where the indexes are
locked at the file system (rather than the process locking that is done by
IndexWriter). You have to ensure that every IndexSearcher is closed (and
properly closed - not just discarded) at the time the 'old' index is wiped,
otherwise it will not be able to swap in the new index, and all index
operations will be broken until you manually go in and fix it.
G
-----Original Message-----
From: Mark Diggory [mailto:[EMAIL PROTECTED]
Sent: 11 February 2007 00:42
To: Graham Triggs
Cc: [EMAIL PROTECTED]; [email protected]
Subject: Re: [Dspace-tech] Reindexing vs Tomcat running
Graham,
I'm not sure if your aware of the rewrite of DSIndexer already sitting further
down on the patch queue that does something similar.
http://sourceforge.net/tracker/index.php?func=detail
<http://sourceforge.net/tracker/index.php?func=detail&aid=1613251&group_id=19984&atid=319984>
&aid=1613251&group_id=19984&atid=319984
-Mark
On Feb 10, 2007, at 7:17 PM, < [EMAIL PROTECTED]> wrote:
Stephane, Jose:
I've just added a revised version of my patch (1655583). I've just added a
catch of IOException around the index version check - providing better/more
appropriate behaviour if that method call fails.
G
----
Graham Triggs
Technical Architect
Open Repository
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk
<http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642_______________________________________________>
&kid=120709&bid=263057&dat=121642_______________________________________________
DSpace-tech mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-tech
Mark R. Diggory
~~~~~~~~~~~~~
DSpace Systems Manager
MIT Libraries, Systems and Technology Services
Massachusetts Institute of Technology
This email has been scanned by Postini.
For more information please visit http://www.postini.com
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
DSpace-tech mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-tech
