For quick clarification:
On Fri, May 27, 2011 at 8:09 AM, Joseph <[email protected]> wrote:
> Dear Dspace-Tech,
>
> This is more of a general best-practices question.
>
> Where should new themes we develop live?
> 1) "
> dspace-source/dspace-xmlui/dspace-xmlui-webapp/src/main/webbapp/themes/"
>
Bad Idea, more specifically, the questions arise: Why would you want to be
repackaging all the xmlui overlay that we've already packaged and released
in the maven repository? Why would you want to incur the cost of building
the entire distribution anytime you want to make a change and test it?
> 2)"dspace-source/dspace/modules/xmlui/src/main/themes/"
>
Good Idea, your code is separate, you know exactly what you've modified, it
doesn't take a fancy tool like git or svn to see the files you've changed.
Generally, when you using a tool like Intellij, the overlays are placed
inside the module your working on so the files are easily accessible there,
likewise, search in IDEA allows you to work within the entire codebase to
find code in any part of the entire dependency tree.
Finally, now, if the core team decides that it wants to move
dspace-xmlui-webapp to be distributed separately from what we call "core",
you'll have to figure out what to do with your changes. It is limiting to
the core team to have to think about this and it is a pain in the butt for
you to have to deal with if we did. the point of the modules directory was
to capture all your changes separate from the codebase so that you would
suffer less during the upgrade process and the core team would be more free
to improve upon the project.
I think rather than core developers recommending altering parts of the
codebase that are either considered wise to keep ones hands off, we need to
understand why we still want to promote doing this and find yet more ways to
improve the process of getting the application developer a cleaner, more
well documented API to program changes against (rather than "hacking the
core").
Mark
>
> The first is what is suggested on the Manikin Theme Tutorial wiki
> https://wiki.duraspace.org/display/DSPACE/Manakin+theme+tutorial
>
> I know most things we develop on our own should probably live in the
> modules directory, that way it's fairly easy to transfer them to a new
> DSpace installation, or an upgrade.
>
>
> Specifically:
> I ran across a problem when using option (2) where, and I'm trying to
> dynamically switch to a development theme I have in a modules directory.
> Using http://<manakin-url>/search?themepath=NewTheme/ I'm able to switch
> to all of the preinstalled themes (Classic, Reference, Kubrick, and Mirage)
> but I'm not able to switch to any that I've created myself.
>
> I get:
> "java.lang.IllegalArgumentException: The user specified theme path,
> "NewTheme/", may be an exploit attempt. To use this feature please limit
> your theme paths to only letters (a-Z), numbers(0-9), dashes(-), underscores
> (_), and trailing forward slashes (/)."
>
> Any ideas what might be going wrong?
>
> Thank You,
> Joseph
>
>
> ------------------------------------------------------------------------------
> vRanger cuts backup time in half-while increasing security.
> With the market-leading solution for virtual backup and recovery,
> you get blazing-fast, flexible, and affordable data protection.
> Download your free trial now.
> http://p.sf.net/sfu/quest-d2dcopy1
> _______________________________________________
> DSpace-tech mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/dspace-tech
>
>
--
Mark R. Diggory
@mire - www.atmire.com
2888 Loker Avenue East - Suite 305 - Carlsbad - CA - 92010
Esperantolaan 4 - Heverlee 3001 - Belgium
------------------------------------------------------------------------------
vRanger cuts backup time in half-while increasing security.
With the market-leading solution for virtual backup and recovery,
you get blazing-fast, flexible, and affordable data protection.
Download your free trial now.
http://p.sf.net/sfu/quest-d2dcopy1
_______________________________________________
DSpace-tech mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-tech
