Le mardi 18 août 2009 à 01:04 +0200, Steve a écrit :
> -------- Original-Nachricht --------
> > Datum: Sun, 16 Aug 2009 09:50:51 +0200
> > Von: Julien Valroff <jul...@kirya.net>
> > An: dspam-devel@lists.sourceforge.net
> > Betreff: Re: [Dspam-devel] Template translations
> 
> > Le jeudi 06 août 2009 à 16:54 +0200, Julien Valroff a écrit :
> > > Hi again,
> > > 
> > > Le jeudi 06 août 2009 à 09:51 +0200, Julien Valroff a écrit :
> > > > Hi,
> > > > 
> > > > As promised, I am working on the template translation into French.
> > > > 
> > > > Some strings are however hardcoded in the cgi ("Empty",
> > "Administrative
> > > > suite")
> > > > 
> > > [...]
> > > 
> > > > I can provide a patch if this is a correct workaround, but would
> > prefer
> > > > your feedback before.
> > > 
> > > I couldn't wait as I was impatient to test my translation...
> > > 
> > > Here is the patch proposal to remove hardcoded strings from the cgi, and
> > > load them from a strings.txt file.
> > 
> > I attach a new patch fixing an issue in the history page which prevented
> > mail to be retrained from the WebUI.
> > 
> Can you say where you patched what regarding the retraining issue?

In dspam.cgi, around line 420, I had translated $rclass = "spam"... and
$rclass = "innocent" ... which are also used to determin the class of
retraining.

Instead, I have used:
        ucfirst($LANG{"history_retrain_as_" . $rclass})
instead of
        ucfirst($rclass)

I see your commit does not include this change. 


> btw: The are some errors in the patch:
> 
> Error 1:
> ---------------------
>        } else {
> -          $cl = "spam"; $cllabel="SPAM";
> +          $cl = "spam"; $cllabel=$LANG{'history_label_spam';
>        }
> ---------------------
> 
> Error 2:
> ---------------------
>      if ($CONFIG{'ADMIN'} == 1) {
> -      $DATA{'NAV_ADMIN'} = qq!<li><a href="admin.cgi">Administrative 
> Suite</a></li>!;
> -      $DATA{'FORM_USER'} = qq!<form action="$CONFIG{'ME'}"><input 
> type=hidden name="template" value="$FORM{'template'}">Statistical SPAM 
> Protection for <INPUT TYPE=TEXT NAME=user SIZE=16 value="$CURRENT_USER"> 
> <input type=submit value="Change"></form>!;
> +      $DATA{'NAV_ADMIN'} = qq!<li><a 
> href="admin.cgi">$LANG{'admin_suite'}</a></li>!;
> +      $DATA{'FORM_USER'} = qq!<form action="$CONFIG{'ME'}"><input 
> type=hidden name="template" value="$FORM{'template'}">$LANG{'user_form'} 
> <INPUT TYPE=TEXT NAME=user SIZE=16 value="$CURRENT_USER"> <input type=submit 
> value=$LANG{'user_f$
>      } else {
> ---------------------

grr, copy&paste error, sorry about this!

Cheers,
Julien


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Dspam-devel mailing list
Dspam-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspam-devel

Reply via email to