On Fri, Nov 16, 2007 at 10:53:59AM -0800, Adam Leventhal wrote: > > > probe name args[2] > > > ---------- ------- > > > nfsv4:::compound-op-start COMPOUND4args * > > > nfsv4:::compound-op-done COMPOUND4res * > > > > > > ... > > > > > > nfsv4:::compound-cb-start CB_COMPOUND4args * > > > nfsv4:::compound-cb-done CB_COMPOUND4res * > > > > COMPOUND is an RPC, things like OPEN are ops inside a compound. So at > > least the names of these probes are inconsistent. > > What names would you suggest?
nfsv4:::compound-start nfsv4:::compound-done nfsv4:::compound-cb-start nfsv4:::compound-cb-done (I.e., drop the "op-" in the client->server compound direction.) > > Also, why not use the 'function' part of the probes to name the > > operation and use "start" and "stop" for the probe names? (Am I > > displaying ignorance of SDT here?) > > Yes :-) The original design for this provider did exactly that, but we > found its implementation more difficult than the modification was useful. Thanks :) _______________________________________________ dtrace-discuss mailing list [email protected]
