Hi! Ralph Glasstetter wrote:
> in the attached patch I implemented the evaluation of bookmarks set in the > proprietary header of Topfield-Receiver Recordings (TF4000PVR, TF5xxxPVR, > TF6xxxPVR... don't know if other Receivers also have that option... maybe > some store this Information in a separate file?). > > I tried to implement this as robust as possible, so if you don't own such a > receiver you shouldn't become aware of that new feature. Nice work. :) But for better modularity, the main code should use a method mpgfile::copy_bookmarks() or similar which is overridden in the tsfile or psfile class as appropriate. In the latter case, the operation would be a no-op, but we could extend it later, e.g. to import chapter marks from VOB files. In addition to that, a common entry point for all kinds of files would render that Evil(tm) dynamic_cast stuff superfluous. > These bookmarks (if found any) are now automatically set in the marker > listbox > on the left and so for instance help to indentify cut positions marked with > the receiver. If you don't like this to occur automatically you can switch it > off in the configuration file with the entry "ts_bookmarks=0". I think that dvbcut should never read the bookmarks automatically. Just consider the case that you re-open a file via the project file - you probably don't want the bookmarks to appear again if you already have a cut list. I think it's better to have an Edit/Import menu item that lets you import the markers explicitly, similar to the Edit/Suggest function. > Furthermore I've now also implemented the "delete all bookmarks" context menu > entry already "suggested" by Michael... ;-) > > And additionally it's now also checked if a marker is already set (otherwise > you would multiply the bookmarks if stored into a project file). However... I > don't think that anyone will miss the current "undocumented feature" of > having thousands of markers for the same frame... ;-) Good idea. [...] > PPS: Ahh, Michael... we've now a picturenr(index)-method! :-) Great! -- Michael "Tired" Riepe <[EMAIL PROTECTED]> X-Tired: Each morning I get up I die a little ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ DVBCUT-user mailing list DVBCUT-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dvbcut-user
