Hi, I'm d'accord with all your suggestions... :D
Am Sonntag, 21. Oktober 2007 13:03 schrieb Michael Riepe: > But for better modularity, the main code should use a method > mpgfile::copy_bookmarks() or similar which is overridden in the tsfile > or psfile class as appropriate. In the latter case, the operation would > be a no-op, but we could extend it later, e.g. to import chapter marks > from VOB files. In addition to that, a common entry point for all kinds > of files would render that Evil(tm) dynamic_cast stuff superfluous. Sounds good...guess that's the right opportunity to learn a little bit more about OOP... ;-) I also was not so pleased with the implementation in dvbcut.cpp, but since my c++ knowledge is rather limited that solution was straightforward... OK, actually that "evil" stuff was a hint from Sven (such things are far beyond my knowlege and even look "evil" to me!). :) > I think that dvbcut should never read the bookmarks automatically. Just > consider the case that you re-open a file via the project file - you > probably don't want the bookmarks to appear again if you already have a > cut list. I think it's better to have an Edit/Import menu item that lets > you import the markers explicitly, similar to the Edit/Suggest function. Ahhh,... you mean you don't want the bookmarks, delete them and every time when reopening the project the bookmarks apear again and again... I didn't considered this... only the doubled bookmarks when opening a project file with saved ones.... Normally hidden automatic features are not good,... but since this one is (at the moment) very special and I was not sure if we would ever have support for a different kind of a input file I decided to do it automatically (with a config switch)... I don't wanted to implement a "Read Topfield Header" menu switch, which would be of no function for people with other receivers. But generally an "Import markers" entry sounds good... I'm sure there are also bookmarks in other receiver specific formats as well as the idea with the imported chapters from VOB files. :-) And I'm sure there are also bookmarks possible with other receiver specific formats (VDR?). I'll have a look how you implemented the "Suggest markers"... hope I don't have to use the QT-Designer for this... ahemmm... ;-) ciao Ralph ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ DVBCUT-user mailing list DVBCUT-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dvbcut-user
