Hi,

First a big thank you for your merging work.

> * r104 is Wolfram's pipe output patch, with minor modifications. I think
> it's better to leave stdout and stderr open, just in case dvdauthor
> wants to print any error messages.

You're right, that's better.  Still better would be to see the output
in the log window..  I'll look into this.  I'll also take a look into
adding a checkbox (or similar) for choosing pipe output.

> Besides that, you must never use
> exit() in a forked child that did not exec properly, because it may
> wreak havoc on your stdio/iostream buffers,

I think not, if all fd's have been closed, but see above.

> signal handlers, allocated
> memory and the like.

That would be news to me, but..

> Always use _exit() instead.

sure, that's definitely correct.

> * r105, finally, contains the compatibility patch for the latest ffmpeg
> trunk (libavformat >= 52.0.0).

I only see r104 on dvbcut.svn.sourceforge.net, but that compat patch
is just a single line like

--- dvbcut/src/lavfmuxer.cpp    2007-11-13 13:22:13.000000000 +0100
+++ dvbcut-wg/src/lavfmuxer.cpp 2007-11-24 18:05:37.000000000 +0100
@@ -120,7 +120,7 @@
     if (fileopened) {
       av_write_trailer(avfc);
       if (!(fmt->flags & AVFMT_NOFILE))
-        url_fclose(&avfc->pb);
+        url_fclose(avfc->pb);
       }
 
     av_free(avfc);

with some #ifdef's, right?

Regards,
Wolfram.


-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
_______________________________________________
DVBCUT-user mailing list
DVBCUT-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dvbcut-user

Reply via email to